refactor(osp): use new company role check #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR related to #1328 |
lavanya-bmw
suggested changes
Dec 8, 2024
| useEffect(() => { | ||
| if ( | ||
| companyDetails?.companyRole.includes( | ||
| CompanyRoleEnum.ONBOARDING_SERVICE_PROVIDER |
There was a problem hiding this comment.
Please also remove ONBOARDING_SERVICE_PROVIDER from CompanyRoleEnum from userApiSlice.ts
There was a problem hiding this comment.
why? This is being used in ConnectorTypeSelection.tsx
There was a problem hiding this comment.
Please use COMPANY_ROLES enum from constants.ts file and remove CompanyRoleEnum(from userApiSlice.ts) and its usage as it is a duplicate enum
…ile. use updated enum from constants
|
kunalgaurav-bmw
approved these changes
Dec 9, 2024
evegufy
approved these changes
Dec 9, 2024
evegufy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove customised logic to check company role info in onboarding service provider (osp) page and header component. use company role check in config file to allow user to navigate to osp page.
Chnagelog
Why
remove custom check for company roles
Issue
#1108
Checklist
Please delete options that are not relevant.