Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(service marketplace): fix detail images #1197

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(service marketplace): fix detail images #1197

wants to merge 4 commits into from

Conversation

Usmanfee
Copy link
Contributor

@Usmanfee Usmanfee commented Oct 4, 2024 •
edited
Loading

Description

Service marketplace and service marketplace detail page has hardcoded images are being displayed. The original image should be displayed incase of its existence otherwise default images would be displayed.

Changelog entry:

- **Service Marketplace**
  - replaced hardcoded images in service marketplace and detail [#1195](https://github.com/eclipse-tractusx/portal-frontend/issues/1195)

Solution

There was one parameter of leadPictureId was missing in response of api which actually contains the image info so with leadPictureId and now by having leadPictureId we are displaying actual images.

Issue

#1195

Checklist

  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have updated CHANGELOG.md file

@Usmanfee Usmanfee mentioned this pull request Oct 4, 2024
Merged
5 tasks
shubhamv-ss
shubhamv-ss approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@shubhamv-ss shubhamv-ss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Usmanfee Usmanfee marked this pull request as ready for review October 10, 2024 08:24
@MaximilianHauer
Copy link

added prio due to dependency with backend development.
@ntruchsess as discussed please review.

typecastcloud
typecastcloud reviewed Oct 14, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Usmanfee Usmanfee force-pushed the fix/service-marketplace-hardcoded-images branch from 03ae3a1 to e66f13f Compare October 15, 2024 08:58
oyo
oyo requested changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@oyo oyo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too much custom image loading logic that already has been implemented. See comments about how to use that. Also please update DEPENDENCIES.

src/components/pages/ServiceAdminBoardDetail/index.tsx Outdated Show resolved Hide resolved
src/components/pages/ServiceAdminBoardDetail/index.tsx Outdated Show resolved Hide resolved
src/components/pages/ServiceMarketplaceDetail/components/MarketplaceHeader/index.tsx Outdated Show resolved Hide resolved
src/components/pages/ServiceMarketplace/index.tsx Outdated Show resolved Hide resolved
@Usmanfee Usmanfee force-pushed the fix/service-marketplace-hardcoded-images branch from b1973f9 to 51847d8 Compare October 17, 2024 13:14
@Usmanfee Usmanfee mentioned this pull request Oct 21, 2024
Open
@Usmanfee Usmanfee requested review from shubhamv-ss and oyo October 21, 2024 11:39
@evegufy evegufy added this to the Release 2.3.0 (24.12) milestone Oct 24, 2024
@Usmanfee Usmanfee force-pushed the fix/service-marketplace-hardcoded-images branch from fee7636 to 3dfd6f7 Compare October 24, 2024 13:55
@evegufy evegufy changed the base branch from main to release/v2.3.0-RC2 October 24, 2024 18:38
evegufy
evegufy requested changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check for build is failing.

Please also remove the changes to changelog and add a note in the PR description.

@evegufy evegufy changed the base branch from release/v2.3.0-RC2 to release/v2.3.0-RC3 November 4, 2024 19:13
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Usmanfee
Copy link
Contributor Author

Usmanfee commented Nov 5, 2024

@evegufy I have reverted the change of changelog file. Regarding build failure, failure is expected since I introduced new changes in shared component which is not yet merged and released so that is why it is failing with linting.

eclipse-tractusx/portal-shared-components#356
this above PR first need to be merged and released in order to fix build failure for this PR.

If you have any other suggestion or work around to address this blocker then please let me know! Thanks

@evegufy
Copy link
Contributor

evegufy commented Nov 7, 2024

@evegufy I have reverted the change of changelog file. Regarding build failure, failure is expected since I introduced new changes in shared component which is not yet merged and released so that is why it is failing with linting.

eclipse-tractusx/portal-shared-components#356 this above PR first need to be merged and released in order to fix build failure for this PR.

If you have any other suggestion or work around to address this blocker then please let me know! Thanks

Hi @Usmanfee ok understood, @oyo is working on the issue why the integration takes to long, just fyi eclipse-tractusx/portal-shared-components#361

@evegufy evegufy changed the title fix(UI): service marketplace and detail images fix(service marketplace): fix detail images Nov 7, 2024
@evegufy evegufy changed the base branch from release/v2.3.0-RC3 to release/v2.3.0-RC4 November 12, 2024 17:10
@evegufy evegufy changed the base branch from release/v2.3.0-RC4 to main November 13, 2024 13:54
@evegufy evegufy removed this from the Release 2.3.0 (24.12) milestone Nov 13, 2024
@evegufy evegufy added this to the Release 25.03 milestone Nov 13, 2024
@manojava-gk
Copy link
Contributor

Resolve conflicts and fix pr checks issue

@lavanya-bmw
Copy link
Contributor

lavanya-bmw commented Dec 12, 2024 •
edited
Loading

Please fix PR checks issue and resolve conflicts.

@lavanya-bmw lavanya-bmw mentioned this pull request Dec 12, 2024
Open
@lavanya-bmw lavanya-bmw self-requested a review December 12, 2024 06:50
@Usmanfee Usmanfee force-pushed the fix/service-marketplace-hardcoded-images branch from 9b082da to 82b8975 Compare December 13, 2024 12:49
@Usmanfee Usmanfee requested a review from evegufy December 13, 2024 13:28
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Usmanfee
Copy link
Contributor Author

@evegufy @manojava-gk can you please a have review now ? I have resolved conflicts and failed pipeline issue. Thanks

lavanya-bmw
lavanya-bmw approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@lavanya-bmw lavanya-bmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typecastcloud typecastcloud typecastcloud left review comments

@lavanya-bmw lavanya-bmw lavanya-bmw approved these changes

@isaadansari isaadansari Awaiting requested review from isaadansari

@JordanGerada3 JordanGerada3 Awaiting requested review from JordanGerada3

@ss-nikunj ss-nikunj Awaiting requested review from ss-nikunj

@ntruchsess ntruchsess Awaiting requested review from ntruchsess

@MaximilianHauer MaximilianHauer Awaiting requested review from MaximilianHauer

@shubhamv-ss shubhamv-ss Awaiting requested review from shubhamv-ss

@oyo oyo Awaiting requested review from oyo

@manojava-gk manojava-gk Awaiting requested review from manojava-gk

@evegufy evegufy Awaiting requested review from evegufy

Requested changes must be addressed to merge this pull request.

Assignees

@oyo oyo

Labels
None yet
Projects
Portal
Status: IN PROGRESS
Milestone
Release 25.03
Development

Successfully merging this pull request may close these issues.
8 participants
@Usmanfee @MaximilianHauer @evegufy @manojava-gk @lavanya-bmw @oyo @typecastcloud @shubhamv-ss