fix: replace logs with appropriate handler #1072
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyo
previously approved these changes
Sep 6, 2024
manojava-gk
reviewed
Sep 9, 2024
CHANGELOG.md
Outdated
| - fixed technical user selection | ||
|
|
||
| ## 2.2.0-RC2 | ||
| ## Unreleased 2.2.0-RC3 |
There was a problem hiding this comment.
this is not related to RC3 changes. Kindly put this change note at the top with title - unreleased
There was a problem hiding this comment.
@manojava-gk updated the changelog
|
evegufy
changed the base branch from
release/v2.3.0-RC2
to
release/v2.3.0-RC3
|
@charmi-v kindly resolve the conflicts |
charmi-v
force-pushed
the
fix/701-replace-logs
branch
from
db22d95 to
d9e1508
Compare
|
|
@manojava-gk conflicts are resolved now |
evegufy
changed the base branch from
release/v2.3.0-RC3
to
release/v2.3.0-RC4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Notify.error for operations without error handling
Added LogService.info for logging responses
Added LogService.error for logging API failures.
Why
The changes were required to improve the error handling and logging within our operations & for operations without error handling, we can ensure that any unexpected issues are properly communicated to the user.
Issue
#701
Checklist