Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: REGEX to allow long company names in BP invite #1007

Merged

Conversation

JordanGerada3
Copy link
Contributor

@JordanGerada3 JordanGerada3 commented Aug 15, 2024

Description

  • Extended pattern with additional currency characters and length adjustment. Min length: 1 Max length: 160
  • Allows " (double quote \x22) to follow back-end implementation.
  • Allows £$€¥¢ to allow some additional currency symbols that are used in existing companies.

Why

Business partner invite company name field was capped at 40 characters blocking the invite of companies with longer business names. REGEX from company name field in registration process has been used to maintain consistency. Backend implementation is also live and ready to accept company name lengths of 160 characters: eclipse-tractusx/portal-backend#860

Issue

eclipse-tractusx/portal#360

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

@typecastcloud
Copy link
Contributor

typecastcloud commented Aug 15, 2024

@Phil91
eclipse-tractusx/portal-frontend-registration#216
Also portal-frontend-registration has this regex.

Tests still need to be adjusted.

Phil91
Phil91 previously approved these changes Aug 16, 2024
This character in company names breaks keycloak.
Copy link

@oyo oyo merged commit 194a81c into eclipse-tractusx:main Aug 19, 2024
8 checks passed
@MaximilianHauer MaximilianHauer added this to the Release 24.12 milestone Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

5 participants