-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: optimize and improve the cax-campanydata.tsx #317
base: main
Are you sure you want to change the base?
refactor: optimize and improve the cax-campanydata.tsx #317
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @shubhamv-ss thank you for the refactoring!
Could you please remove the changelog entry from the CHANGELOG.md file and add it instead to the PR description? (example)
Please also remove all irrelevant options:
@lavanya-bmw @kunalgaurav-bmw @manojava-gk Please review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update template header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the sonarcloud issue.
Please add changelog entry in PR description and remove from changelog file and Please also remove all irrelevant options from the checklist(Please address Evelyn's comments).
Please update template header ( address Manojava's comments).
d3d9892
to
9e8aebb
Compare
@shubhamv-ss pls address translation comment from Lavanya. Also fix sonar cloud issue. Rest looks fine to me |
Quality Gate passedIssues Measures |
Description
cax-companyData.tsx
to ensure maintainability, scalability, and performance.Why
Issue
cax-companyData
Page #316Checklist