Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimize and improve the cax-campanydata.tsx #317

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

shubhamv-ss
Copy link
Contributor

@shubhamv-ss shubhamv-ss commented Nov 26, 2024

Description

  • Improved and optimized cax-companyData.tsx to ensure maintainability, scalability, and performance.
  • Changelog entry:
Refactor, optimise and reorganise the code in cax-companyData.tsx file [#317](https://github.com/eclipse-tractusx/portal-frontend-registration/pull/317)

Why

  • Reusability: Refactoring the code can make it more modular and reusable, reducing code duplication and improving maintainability.
  • Performance: Optimizing the code will improve the page's rendering speed and overall performance, leading to a better user experience.
  • Readability and Understandability: Improving code organization, naming conventions, and commenting will make the code easier to understand and maintain.
  • Testability: By breaking down the code into smaller, more manageable pieces, we can improve test coverage and make it easier to write unit tests.

Issue

Checklist

  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

@shubhamv-ss shubhamv-ss marked this pull request as ready for review November 28, 2024 09:54
@evegufy evegufy changed the title fix: optimize, refactor the cax-campanydata.tsx refactor: optimize and improve the cax-campanydata.tsx Dec 4, 2024
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shubhamv-ss thank you for the refactoring!

Could you please remove the changelog entry from the CHANGELOG.md file and add it instead to the PR description? (example)

Please also remove all irrelevant options:

image

@lavanya-bmw @kunalgaurav-bmw @manojava-gk Please review

Copy link
Contributor

@manojava-gk manojava-gk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update template header

src/components/CompanyData/AddressForm.tsx Outdated Show resolved Hide resolved
src/components/CompanyData/CompanyDataForm.tsx Outdated Show resolved Hide resolved
src/components/CompanyData/Identiifier.tsx Outdated Show resolved Hide resolved
src/helpers/constants.ts Outdated Show resolved Hide resolved
src/helpers/validation.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@lavanya-bmw lavanya-bmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the sonarcloud issue.
Please add changelog entry in PR description and remove from changelog file and Please also remove all irrelevant options from the checklist(Please address Evelyn's comments).
Please update template header ( address Manojava's comments).

src/components/CompanyData/CompanyDataForm.tsx Outdated Show resolved Hide resolved
src/components/CompanyData/CompanyDataForm.tsx Outdated Show resolved Hide resolved
src/components/CompanyData/CompanyDataForm.tsx Outdated Show resolved Hide resolved
src/helpers/validation.ts Outdated Show resolved Hide resolved
src/helpers/validation.ts Outdated Show resolved Hide resolved
src/helpers/validation.ts Outdated Show resolved Hide resolved
src/helpers/validation.ts Show resolved Hide resolved
src/helpers/validation.ts Outdated Show resolved Hide resolved
src/locales/en/translations.json Show resolved Hide resolved
@shubhamv-ss shubhamv-ss force-pushed the fix/code-improvement-in-caxCompanyData branch from d3d9892 to 9e8aebb Compare December 17, 2024 11:51
@manojava-gk
Copy link
Contributor

@shubhamv-ss pls address translation comment from Lavanya. Also fix sonar cloud issue. Rest looks fine to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: IN PROGRESS
Development

Successfully merging this pull request may close these issues.

5 participants