Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove logic that sets bpn before validation #253

Merged
merged 5 commits into from
Oct 21, 2024
Merged

fix: remove logic that sets bpn before validation #253

merged 5 commits into from
Oct 21, 2024

Conversation

JordanGerada3
Copy link
Contributor

@JordanGerada3 JordanGerada3 commented Sep 13, 2024 •
edited
Loading

Description

  • Removed prop from input field that was setting the BPNL on the form without being firstly validated

Why

When a user would insert an invalid BPNL in the autofill field, the BPNL was updating in the form despite being invalid, leading to the possibility of the user submitting the application with an incorrect BPNL.

Issue

#252

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have checked that new and existing tests pass locally with my changes

typecastcloud
typecastcloud approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@typecastcloud typecastcloud left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Unintended behavior by the copy paste mess I made when adding onBlur logic. Thanks for the find!

Please update DEPENDENCIES file.
See artifact here: https://github.com/eclipse-tractusx/portal-frontend-registration/actions/runs/10845856689

@JordanGerada3
Copy link
Contributor Author

Looks good. Unintended behavior by the copy paste mess I made when adding onBlur logic. Thanks for the find!

Please update DEPENDENCIES file. See artifact here: https://github.com/eclipse-tractusx/portal-frontend-registration/actions/runs/10845856689

DEPENDENCIES updated!

shubhamv-ss
shubhamv-ss approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@shubhamv-ss shubhamv-ss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MaximilianHauer MaximilianHauer added this to the Release 24.12 milestone Sep 13, 2024
@MaximilianHauer MaximilianHauer requested a review from oyo September 13, 2024 14:47
@JordanGerada3 JordanGerada3 requested a review from evegufy October 1, 2024 11:14
evegufy
evegufy requested changes Oct 9, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@JordanGerada3 JordanGerada3 requested a review from evegufy October 9, 2024 14:51
evegufy
evegufy approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you @JordanGerada3

evegufy
evegufy requested changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, didn't see it earlier, could you please still update the DEPENDENCIES file again?

@JordanGerada3
Copy link
Contributor Author

sorry, didn't see it earlier, could you please still update the DEPENDENCIES file again?

@evegufy it seems that the failure happened before the artefact generation, therefore I have nothing to update the dependencies with. I also haven't introduced any new dependencies in my PR. Do you know how to solve this?

@evegufy
Copy link
Contributor

evegufy commented Oct 21, 2024

@JordanGerada3 sorry for the wait. We'll update the dependencies with another PR as this change doesn't include update to dependencies.

@evegufy evegufy merged commit 992e973 into eclipse-tractusx:main Oct 21, 2024
7 checks passed
@JordanGerada3 JordanGerada3 deleted the fix/252-user-still-able-to-register-with-non-existent-bpn branch October 21, 2024 13:12
@typecastcloud typecastcloud mentioned this pull request Oct 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamv-ss shubhamv-ss shubhamv-ss approved these changes

@evegufy evegufy evegufy approved these changes

@typecastcloud typecastcloud Awaiting requested review from typecastcloud

@MaximilianHauer MaximilianHauer Awaiting requested review from MaximilianHauer

@oyo oyo Awaiting requested review from oyo

Assignees
No one assigned
Labels
None yet
Projects
Portal
Status: USER READY
Milestone
Release 2.1.0 (24.12)
Development

Successfully merging this pull request may close these issues.
5 participants
@JordanGerada3 @evegufy @typecastcloud @shubhamv-ss @MaximilianHauer