Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(company data): remove onBlur event handler in radio identifier select #247

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

typecastcloud
Copy link
Contributor

@typecastcloud typecastcloud commented Aug 19, 2024

Description

Fix for bug introduced by me in: #210

Remove onBlur from radio selection since this invalidated already accepted data.

Why

OnBlur caused issues when receiving multiple identifier via BPDM and invalidated data.
image

Issue

Refs: #190

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have checked that new and existing tests pass locally with my changes

Copy link

@typecastcloud typecastcloud requested a review from oyo August 19, 2024 13:46
@MaximilianHauer MaximilianHauer added this to the Release 24.12 milestone Sep 13, 2024
oyo
oyo previously approved these changes Oct 21, 2024
Copy link
Contributor

@oyo oyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@typecastcloud contribution approved - please resolve merge conflicts

@typecastcloud typecastcloud force-pushed the fix/onBlur-data-invalidation branch from e1c75ee to 36a559c Compare October 21, 2024 13:27
Copy link

@oyo oyo merged commit 0591311 into eclipse-tractusx:main Oct 21, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

3 participants