Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: roles not updating while registration in role selection and data verification steps. #214

Conversation

shubhamv-ss
Copy link
Contributor

@shubhamv-ss shubhamv-ss commented Jul 11, 2024

Description

Roles are not updated during the registration process in role selection and data verification steps if the user navigates between steps.

Why

  • When completing the registration, on third steps if we select any roles and navigate till last step, where we have selected roles section.
  • Now if user navigate back to the third step, made some changes.
  • Again navigate to last step, here these roles are not getting updated.
  • Navigate back to third step, you will see the old data instead of latest roles.
  • This issue is addressed in this MR

Issue

Link to Github issue: #212

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

…ion and verification steps, if user navigate between steps.
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shubhamv-ss thank you for the contribution!
could you please sign the Eclipse Contributor Agreement? https://accounts.eclipse.org/user/eca
and please shorten the pull request title, it's quite long, could you please summarise?

@shubhamv-ss shubhamv-ss changed the title fix: roles are not updating while registration process in role selection and data verification steps if user navigate between steps. fix: roles not updating while registration in role selection and data verification steps. Jul 11, 2024
Copy link
Contributor

@typecastcloud typecastcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why/description are the same. Maybe list/explain changes a bit more.

@typecastcloud
Copy link
Contributor

Please recreate with correct email in commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants