Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): add full dockerfile containing yarn step #187

Merged

Conversation

typecastcloud
Copy link
Contributor

@typecastcloud typecastcloud commented Jun 4, 2024

Description

Full build dockerfile for frontend registration image with yarn stage.

Why

We can create images without yarn installed and this change streamlines dockerfiles across portal repositories.

Issue

Refs: #186

Checklist

  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

We can create images without yarn installed and this change streamlines dockerfiles across portal repositories.

Refs: eclipse-tractusx#186
@oyo oyo requested review from oyo and evegufy June 10, 2024 12:07
oyo
oyo previously approved these changes Jun 10, 2024
Copy link
Contributor

@oyo oyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update year in license header - otherwise looks good
@evegufy please also have a look

.conf/Dockerfile.full Outdated Show resolved Hide resolved
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@typecastcloud typecastcloud requested a review from oyo June 10, 2024 15:21
@typecastcloud
Copy link
Contributor Author

@evegufy @oyo any update on this?

Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the late review, looks good in general.

I'd just change the base branch to dev as we still have that the dev flow in place for this repo.

And another thing: could you please rename the prebuilt dockerfile to Dockerfile.prebuilt and adjust the referencing in the workflow files accordingly, example, so that we improve also on the understanding of why there are now two dockerfiles.

Thank you!

@typecastcloud typecastcloud changed the base branch from main to dev June 17, 2024 08:16
@typecastcloud typecastcloud requested a review from evegufy June 17, 2024 08:25
@typecastcloud
Copy link
Contributor Author

sorry for the late review, looks good in general.

I'd just change the base branch to dev as we still have that the dev flow in place for this repo.

And another thing: could you please rename the prebuilt dockerfile to Dockerfile.prebuilt and adjust the referencing in the workflow files accordingly, example, so that we improve also on the understanding of why there are now two dockerfiles.

Thank you!

Hi Evelyn,

Thanks for the reply. At first I did not want to touch the existing Dockerfile since external workflows/jobs might be using the previous name.

I can't fully evaluate the risks but made the requested changes.

Cheers

@evegufy evegufy changed the title feat(build): add full dockerfile containing yarn step chore(build): add full dockerfile containing yarn step Jun 17, 2024
@evegufy evegufy merged commit b474d88 into eclipse-tractusx:dev Jun 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants