-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(build): add full dockerfile containing yarn step #187
chore(build): add full dockerfile containing yarn step #187
Conversation
We can create images without yarn installed and this change streamlines dockerfiles across portal repositories. Refs: eclipse-tractusx#186
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update year in license header - otherwise looks good
@evegufy please also have a look
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the late review, looks good in general.
I'd just change the base branch to dev as we still have that the dev flow in place for this repo.
And another thing: could you please rename the prebuilt dockerfile to Dockerfile.prebuilt
and adjust the referencing in the workflow files accordingly, example, so that we improve also on the understanding of why there are now two dockerfiles.
Thank you!
Hi Evelyn, Thanks for the reply. At first I did not want to touch the existing Dockerfile since external workflows/jobs might be using the previous name. I can't fully evaluate the risks but made the requested changes. Cheers |
Description
Full build dockerfile for frontend registration image with yarn stage.
Why
We can create images without yarn installed and this change streamlines dockerfiles across portal repositories.
Issue
Refs: #186
Checklist