Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(trg-4-07): enable container for readOnlyRootFilesystem #110

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

evegufy
Copy link
Contributor

@evegufy evegufy commented Feb 1, 2024

Description

  • enable container for readOnlyRootFilesystem with symlink to tmp for index.html
  • enhance comments in scripts

Why

https://eclipse-tractusx.github.io/docs/release/trg-0/trg-4-07

Issue

eclipse-tractusx/portal#159

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have commented my code, particularly in hard-to-understand areas

- enable container for readOnlyRootFilesystem with symlink to tmp for index.html
- enhance comments in scripts
Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@evegufy evegufy requested a review from Phil91 February 1, 2024 13:40
@evegufy evegufy merged commit 00e5f46 into release/v1.6.0-RC4 Feb 1, 2024
6 checks passed
@evegufy evegufy deleted the build/readOnlyRootFilesystem branch February 1, 2024 15:09
evegufy added a commit to eclipse-tractusx/portal that referenced this pull request Feb 2, 2024
- enable readOnlyRootFilesystem in containers
- mount tmp frontend deployment, required by nginx base image but also by 00-inject-dynamic-env.sh (executed via docker entrypoint) for [portal](eclipse-tractusx/portal-frontend#471) and [registration app](eclipse-tractusx/portal-frontend-registration#110)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants