Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clearinghouse): add auto retrigger for END_CLEARINGHOUSE #958

Merged
merged 5 commits into from
Sep 17, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Aug 28, 2024

Description

enable maintenance worker to retrigger the clearinghouse process

Why

To enable an auto retrigger for the clearinghouse process if the END_CLEARINGHOUSE is on TODO for a certain time.

Issue

Refs: #810

Corresponding CD PR

eclipse-tractusx/portal#418

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take care of codeql findings

@Phil91 Phil91 requested a review from evegufy September 13, 2024 06:15
@Phil91 Phil91 force-pushed the feature/810-clearinghouse branch from 79040da to bcbbc9d Compare September 13, 2024 06:16
@ntruchsess ntruchsess force-pushed the feature/810-clearinghouse branch 3 times, most recently from b5feda5 to 05a150e Compare September 16, 2024 20:08
Copy link
Contributor

@ntruchsess ntruchsess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've refactored some hard to read code, removed some reduncancy and moved code to where it belongs (calls on dbcontext into repo).
remark: not all scanner findings give good guidance to create better understandable code - e.g. implicitly selecting (caused by use of async lambda) into a task in the foreach-loop where that task is awaited at a different location might not be understud by every developer at the first glance. I did add a new factory-method that turns IEnumerable<Task> into IAsyncEnumerable which allows to await the tasks directly in the foreach.
There is one comment you should check (new unreferenced setting) and 4 scanner-findings I leave up to you to resolve ;-)

@ntruchsess ntruchsess force-pushed the feature/810-clearinghouse branch from 05a150e to 721525d Compare September 16, 2024 20:24
@ntruchsess
Copy link
Contributor

@Phil91 : had to replace END_CLEARINGHOUSE by AWAIT_CLEARING_HOUSE_RESPONSE as per rebase on main. From my understanding that should just have been a rename without semantic changes?

@Phil91 Phil91 force-pushed the feature/810-clearinghouse branch from 721525d to 4069141 Compare September 17, 2024 09:56
@Phil91
Copy link
Member Author

Phil91 commented Sep 17, 2024

@Phil91 : had to replace END_CLEARINGHOUSE by AWAIT_CLEARING_HOUSE_RESPONSE as per rebase on main. From my understanding that should just have been a rename without semantic changes?

@ntruchsess correct :)

@Phil91 Phil91 requested a review from ntruchsess September 17, 2024 10:00
@Phil91
Copy link
Member Author

Phil91 commented Sep 17, 2024

I've refactored some hard to read code, removed some reduncancy and moved code to where it belongs (calls on dbcontext into repo). remark: not all scanner findings give good guidance to create better understandable code - e.g. implicitly selecting (caused by use of async lambda) into a task in the foreach-loop where that task is awaited at a different location might not be understud by every developer at the first glance. I did add a new factory-method that turns IEnumerable into IAsyncEnumerable which allows to await the tasks directly in the foreach. There is one comment you should check (new unreferenced setting) and 4 scanner-findings I leave up to you to resolve ;-)

@ntruchsess fixed the sonar findings and removed the unnecessary setting

Copy link

@ntruchsess ntruchsess dismissed evegufy’s stale review September 17, 2024 10:18

code-ql findings were solved

@ntruchsess ntruchsess merged commit bea374c into main Sep 17, 2024
12 checks passed
@ntruchsess ntruchsess deleted the feature/810-clearinghouse branch September 17, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

sig#802: Registration process - Retriggering 'Clearinghouse' Step in Registration Approval Process
3 participants