-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clearinghouse): add auto retrigger for END_CLEARINGHOUSE #958
Conversation
src/externalsystems/Clearinghouse.Library/BusinessLogic/ClearinghouseBusinessLogic.cs
Fixed
Show fixed
Hide fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take care of codeql findings
src/maintenance/Maintenance.App/DependencyInjection/MaintenanceServiceExtensions.cs
Outdated
Show resolved
Hide resolved
src/maintenance/Maintenance.App/DependencyInjection/BatchDeleteServiceSettings.cs
Outdated
Show resolved
Hide resolved
...administration/Administration.Service/Extensions/CompanyApplicationStatusFilterExtensions.cs
Show resolved
Hide resolved
79040da
to
bcbbc9d
Compare
b5feda5
to
05a150e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've refactored some hard to read code, removed some reduncancy and moved code to where it belongs (calls on dbcontext into repo).
remark: not all scanner findings give good guidance to create better understandable code - e.g. implicitly selecting (caused by use of async lambda) into a task in the foreach-loop where that task is awaited at a different location might not be understud by every developer at the first glance. I did add a new factory-method that turns IEnumerable<Task> into IAsyncEnumerable which allows to await the tasks directly in the foreach.
There is one comment you should check (new unreferenced setting) and 4 scanner-findings I leave up to you to resolve ;-)
src/administration/Administration.Service/DependencyInjection/PartnerRegistrationSettings.cs
Outdated
Show resolved
Hide resolved
...administration/Administration.Service/Extensions/CompanyApplicationStatusFilterExtensions.cs
Show resolved
Hide resolved
05a150e
to
721525d
Compare
src/portalbackend/PortalBackend.DBAccess/Repositories/DocumentRepository.cs
Fixed
Show fixed
Hide fixed
@Phil91 : had to replace END_CLEARINGHOUSE by AWAIT_CLEARING_HOUSE_RESPONSE as per rebase on main. From my understanding that should just have been a rename without semantic changes? |
enable maintenance worker to retrigger the clearinghouse process Refs: #810
721525d
to
4069141
Compare
@ntruchsess correct :) |
@ntruchsess fixed the sonar findings and removed the unnecessary setting |
Quality Gate passedIssues Measures |
Description
enable maintenance worker to retrigger the clearinghouse process
Why
To enable an auto retrigger for the clearinghouse process if the END_CLEARINGHOUSE is on TODO for a certain time.
Issue
Refs: #810
Corresponding CD PR
eclipse-tractusx/portal#418
Checklist