Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(processes): adjust retriggers #915

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Aug 12, 2024

Description

  • add missing endpoints to retrigger failed steps
  • add retrigger steps and endpoints for process steps which miss a retrigger step

Why

There are retrigger steps without an endpoint to retrigger them and some processes are missing a retrigger step.

Issue

Refs: #912

CD PR

eclipse-tractusx/portal-assets#386

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

Copy link

sonarqubecloud bot commented Aug 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
4 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Phil91 Phil91 marked this pull request as ready for review August 12, 2024 10:34
@Phil91 Phil91 requested review from ntruchsess and evegufy and removed request for ntruchsess August 12, 2024 10:34
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you notice the 4 new issues by sonarcloud?
Can they, or some of them, be addressed?

@Phil91
Copy link
Member Author

Phil91 commented Aug 14, 2024

Did you notice the 4 new issues by sonarcloud? Can they, or some of them, be addressed?

@evegufy yes, did saw them and had a look at them, those are all because of the migration. I wouldn't address them. But I mark them as won't do on sonar with an appropriate comment

@ntruchsess ntruchsess force-pushed the feature/912-adjust-retrigger branch 3 times, most recently from caefe79 to c56f530 Compare September 12, 2024 13:38
* add missing endpoints to retrigger failed steps
* add retrigger steps and endpoints for process steps which miss a retrigger step

Refs: #912
@ntruchsess ntruchsess force-pushed the feature/912-adjust-retrigger branch 2 times, most recently from 388936e to 8d2da2f Compare September 12, 2024 14:49
@ntruchsess ntruchsess force-pushed the feature/912-adjust-retrigger branch from 8d2da2f to 7dd2627 Compare September 12, 2024 15:32
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

3 participants