chore(code-quality): fix various findings #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntruchsess
force-pushed
the
chore/694-code-quality
branch
4 times, most recently
from
2763df2 to
c130c86
Compare
4 tasks
ntruchsess
changed the title
ntruchsess
force-pushed
the
chore/694-code-quality
branch
from
c130c86 to
874c60c
Compare
Phil91
previously approved these changes
Jul 24, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ntruchsess
force-pushed
the
chore/694-code-quality
branch
from
874c60c to
dce9e36
Compare
|
Phil91
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
namespace Offers.Library.Extensions has been changed to Org.Eclipse.TractusX.Portal.Backend.Offers.Library.Extensions
propper errorhandling has been added to ProcessStepExtensions and unit-tests were added.
Why
Improve maintainability and adherence to standards.
Issue
#694
Checklist
Please delete options that are not relevant.