Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(registration): make submit document type validation optional #853

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dhiren-singh-007
Copy link
Contributor

@dhiren-singh-007 dhiren-singh-007 commented Jul 19, 2024

Description

As an Operator, we discovered that we don’t necessarily need documents to be submitted during registration.
We manage all the documents during the sales process before the Portal registration process.
We want to make the document submission step optional.
So We added a configuration IsSubmitDocumentValidationOptional (thanks for the suggestion by @ntruchsess )
So if this flag is true then we will skip only the validation of submit document (But someone can still attach the document).
And if the flag is false then it will work like as before.

Configuration : IsSubmitDocumentValidationOptional
Default value : false

Why

Currently it's mandatory to upload the document before registration submit. So to make it optional we have added this flag

Issue

Issue : 828

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes

Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dhiren-singh-007 thank you for the contribution!
Just our 2.1.0 version is closed for feature changes, could you direct the pr to the main branch?

@dhiren-singh-007 dhiren-singh-007 changed the base branch from release/v2.1.0-RC2 to main July 19, 2024 14:05
@dhiren-singh-007
Copy link
Contributor Author

Hi @dhiren-singh-007 thank you for the contribution! Just our 2.1.0 version is closed for feature changes, could you direct the pr to the main branch?

Thanks for the update , changed it to main

@evegufy evegufy self-requested a review July 24, 2024 16:56
@jjeroch jjeroch added the merge postponed the merge of this PR shall be postponed until all prerequisites are fulfilled label Jul 24, 2024
@Phil91 Phil91 added this to the Release 24.12 milestone Aug 14, 2024
@MaximilianHauer
Copy link

MaximilianHauer commented Oct 22, 2024

@stephanbcbauer / @ma3u i asked to discuss this topic in the NES Committee to find a decision.
Please help me raising the topic in the meetings as i am on vacation next week and we would need to find an alignment here.
i checked if we have a standard defining how the handling of identification documentation should be done if its necessary to be uploaded via the portal or only in the responsibility of the cx-operator no matter how he handles/saves the documents but was not finding a clear specification

@dhiren-singh-007 dhiren-singh-007 force-pushed the improvement/828-submit-document-validation-optional branch from bc393d5 to b8a655a Compare October 24, 2024 12:55
Copy link

@evegufy evegufy removed this from the Release 2.3.0 (24.12) milestone Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge postponed the merge of this PR shall be postponed until all prerequisites are fulfilled
Projects
Status: No status
5 participants