-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(registration): make submit document type validation optional #853
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dhiren-singh-007 thank you for the contribution!
Just our 2.1.0 version is closed for feature changes, could you direct the pr to the main branch?
Thanks for the update , changed it to main |
@stephanbcbauer / @ma3u i asked to discuss this topic in the NES Committee to find a decision. |
bc393d5
to
b8a655a
Compare
Quality Gate passedIssues Measures |
Description
As an Operator, we discovered that we don’t necessarily need documents to be submitted during registration.
We manage all the documents during the sales process before the Portal registration process.
We want to make the document submission step optional.
So We added a configuration
IsSubmitDocumentValidationOptional
(thanks for the suggestion by @ntruchsess )So if this flag is true then we will skip only the validation of submit document (But someone can still attach the document).
And if the flag is false then it will work like as before.
Configuration :
IsSubmitDocumentValidationOptional
Default value : false
Why
Currently it's mandatory to upload the document before registration submit. So to make it optional we have added this flag
Issue
Issue : 828
Checklist
Please delete options that are not relevant.