fix(getAppRoles): change permissions #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
permission 'view_client_roles' has been changed for the following APIs
GET /api/apps/AppChange/{appId}/roles => new permission validation as 'edit_apps'
GET /api/apps/AppReleaseProcess/{appId}/roles => new permission validation as 'add_apps'
[Refs: 826](eclipse-tractusx#826)
|
PR has been raised from release branch https://github.com/eclipse-tractusx/portal-backend/tree/release/v2.1.0-RC1 as per @evegufy 's request. |
evegufy
changed the title
evegufy
approved these changes
Jul 10, 2024
evegufy
merged commit 7e1447a
into
eclipse-tractusx:release/v2.1.0-RC1
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
view_clinet_rolesis supposed to get used when it comes to actual role assignment. Since the App Manager is not supposed to assign roles to company users, the permission is not expected to be assigned.Instead the permission of the following endpoints need to get switched
edit_appsadd_appsWhy
App manager encounters 403 error on Technical Integration while registering an app.
Issue
Refs: 826
Checklist
Please delete options that are not relevant.