Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(clearinghouse): add feature toggle for sd connectivity #793

Merged
merged 1 commit into from
Jun 25, 2024
Merged

feat(clearinghouse): add feature toggle for sd connectivity #793

merged 1 commit into from
Jun 25, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Jun 19, 2024 •
edited
Loading

Description

Add feature toggle to disable all sd factory calls for the application checklist and connector registration

Why

To be able to switch off the sd factory connection

Issue

#792

Corresponding Portal PR

eclipse-tractusx/portal#344

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 mentioned this pull request Jun 19, 2024
Merged
4 tasks
@Phil91 Phil91 changed the title Feature/792 clearinghouse feat(clearinghouse): add feature toggle for sd connectivity Jun 19, 2024
@Phil91 Phil91 force-pushed the feature/792-clearinghouse branch from 075ab73 to 93538b7 Compare June 20, 2024 09:24
@Phil91 Phil91 marked this pull request as ready for review June 20, 2024 10:06
@Phil91 Phil91 requested review from ntruchsess and evegufy June 21, 2024 07:04
@Phil91 Phil91 force-pushed the feature/792-clearinghouse branch from 93538b7 to e7795a4 Compare June 24, 2024 08:52
@Phil91 Phil91 requested a review from evegufy June 24, 2024 08:52
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Phil91 Phil91 merged commit 03f9dcb into release/v2.1.0-RC1 Jun 25, 2024
11 checks passed
@Phil91 Phil91 deleted the feature/792-clearinghouse branch June 25, 2024 10:36
@ipa-big ipa-big mentioned this pull request Jul 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evegufy evegufy evegufy approved these changes

@ntruchsess ntruchsess Awaiting requested review from ntruchsess

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Phil91 @evegufy