Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(subscriptionConfig): adjust url null case #783

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented May 29, 2024

Description

adjust handling if url null is send when no provider company detail is set

Why

when trying to set url to null if no provider company detail is existing the endpoint throws a 500 error

Issue

N/A

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

adjust handling if url null is send when no provider company detail is set
@Phil91 Phil91 requested a review from evegufy May 29, 2024 07:45
@Phil91
Copy link
Member Author

Phil91 commented May 29, 2024

@jjeroch should this PR be provided as a hotfix for the last release?

@evegufy /cc

@Phil91 Phil91 requested a review from ntruchsess May 29, 2024 14:25
ntruchsess
ntruchsess previously approved these changes Jun 3, 2024
@ntruchsess ntruchsess added the bug Something isn't working label Jun 4, 2024
@evegufy
Copy link
Contributor

evegufy commented Jun 4, 2024

IP issue created for failing dependencies check:https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/15073
(not caused by this change but EF Dash Tool decided that it requires an IP issue for that package)

@evegufy
Copy link
Contributor

evegufy commented Jun 4, 2024

@jjeroch should this PR be provided as a hotfix for the last release?

@evegufy /cc

I set the milestone to 2.1.0, also after discussing with @ntruchsess

Copy link

sonarqubecloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@evegufy evegufy merged commit fbdd4f3 into eclipse-tractusx:dev Jun 4, 2024
11 checks passed
@evegufy evegufy deleted the bugfix/setprovider branch June 4, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants