Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve dependabot and rework file header #737

Merged
merged 3 commits into from
May 15, 2024

Conversation

evegufy
Copy link
Contributor

@evegufy evegufy commented May 15, 2024

Description

dependabot group version updates
chore: rework year in file header

Why

eclipse-tractusx/portal#300
eclipse-tractusx/portal#234

Checklist

@evegufy evegufy force-pushed the chore/dependabot_file-header branch 2 times, most recently from 3f2f80e to 6961499 Compare May 15, 2024 09:17
@evegufy evegufy changed the title chore: upgrade packages and improve dependabot chore: upgrade packages and rework file header May 15, 2024
@evegufy evegufy changed the title chore: upgrade packages and rework file header chore: improve dependabot and rework file header May 15, 2024
@evegufy evegufy marked this pull request as draft May 15, 2024 09:21
@evegufy evegufy force-pushed the chore/dependabot_file-header branch from 2fa7218 to 7cb3344 Compare May 15, 2024 12:44
@evegufy evegufy requested review from Phil91 and ntruchsess May 15, 2024 12:57
@evegufy evegufy marked this pull request as ready for review May 15, 2024 13:00
@evegufy
Copy link
Contributor Author

evegufy commented May 15, 2024

@Phil91 I'm not sure how to proceed with the failing check for the nuget packages? https://github.com/eclipse-tractusx/portal-backend/actions/runs/9095882443/job/25000084520?pr=737
Can we ignore it in this case, or will that lead to issues after merge?

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@evegufy
Copy link
Contributor Author

evegufy commented May 15, 2024

@Phil91 I'm not sure how to proceed with the failing check for the nuget packages? https://github.com/eclipse-tractusx/portal-backend/actions/runs/9095882443/job/25000084520?pr=737 Can we ignore it in this case, or will that lead to issues after merge?

I decided to raise the patch version, just in case

@evegufy evegufy merged commit 24b3d41 into release/v2.0.0-RC8 May 15, 2024
11 checks passed
@evegufy evegufy deleted the chore/dependabot_file-header branch May 15, 2024 14:22
@Phil91
Copy link
Member

Phil91 commented May 15, 2024

@Phil91 I'm not sure how to proceed with the failing check for the nuget packages? https://github.com/eclipse-tractusx/portal-backend/actions/runs/9095882443/job/25000084520?pr=737 Can we ignore it in this case, or will that lead to issues after merge?

theoretically this should not be a problem since we only edited the file header. but to be on the safe side we should upgrade the version of the packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants