Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable multiple technical user for offers #1197

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Dec 3, 2024

Description

Remove the limitation to only have one technical user per offer

Why

To create multiple technical users for an offer

Issue

Refs: #1136

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 requested review from ntruchsess and evegufy December 3, 2024 07:25
@Phil91 Phil91 added this to the Release 25.03 milestone Dec 3, 2024
Copy link

sonarqubecloud bot commented Dec 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
4 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Phil91 Phil91 requested a review from typecastcloud December 12, 2024 09:16
typecastcloud

This comment was marked as outdated.

@Phil91
Copy link
Member Author

Phil91 commented Dec 18, 2024

@typecastcloud no the frontend didn't adjust the logic yet, but we could already merge the backend since it only enables the creation without changing any request nor response type to the frontend

Copy link
Contributor

@typecastcloud typecastcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed, built and tested the code. Approval from me.

Tech user/service account naming conventions still cause some confusion but that will take some time to streamline I guess.

@Phil91
Copy link
Member Author

Phil91 commented Dec 18, 2024

I have reviewed, built and tested the code. Approval from me.

Tech user/service account naming conventions still cause some confusion but that will take some time to streamline I guess.

Would maybe make sense if you could add an issue for that? than we could continue the discussion on what's needed there

@Phil91 Phil91 merged commit 4cdba4c into main Dec 18, 2024
11 checks passed
@Phil91 Phil91 deleted the feature/1136-technical-user branch December 18, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

2 participants