Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(BpnDidService): Transition from API Key to Technical User Authentication for BDRS Integration (#59) #1129

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tfjanjua
Copy link
Contributor

@tfjanjua tfjanjua commented Nov 5, 2024

Description

We need to update the authentication mechanism for our portal's integration with the BDRS. The current implementation uses an API Key, but it is needed to switch to a new authentication method using a technical user with client ID and secret.

Why

The endpoints the portal is hitting remain unchanged, however, the error handling got improved to support the new errors provided with the technical user authentication method.

Issue

Ref: #1078

Corresponding Configuration PR

eclipse-tractusx/portal#474

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@tfjanjua tfjanjua self-assigned this Nov 5, 2024
@tfjanjua tfjanjua added the enhancement New feature or request label Nov 5, 2024
Copy link
Member

@Phil91 Phil91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before approving I'd wait for the PRs to adjust the configuration in the portal repo and add the technical user in the portal-iam repo

@tfjanjua
Copy link
Contributor Author

tfjanjua commented Nov 5, 2024

Before approving I'd wait for the PRs to adjust the configuration in the portal repo and add the technical user in the portal-iam repo

@Phil91 configuration PR has been attached

Seed data (related to Service Account of BDRS Management) still needs to be part of this PR

Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes so that the PR doesn't get merged until there's an according change on BDRS side eclipse-tractusx/sig-release#959 (comment)

@tfjanjua
Copy link
Contributor Author

tfjanjua commented Nov 5, 2024

Requesting changes so that the PR doesn't get merged until there's an according change on BDRS side eclipse-tractusx/sig-release#959 (comment)

Just FYI: @evegufy | @Phil91, I have added Seed Data for a technical user for BDRS Management

@ntruchsess ntruchsess force-pushed the feat/1078-api-key-to-technical-user-auth-for-BDRS branch from 6f84f0d to 3d969b4 Compare November 13, 2024 23:47
@ntruchsess ntruchsess force-pushed the feat/1078-api-key-to-technical-user-auth-for-BDRS branch from 3d969b4 to e4435a5 Compare November 13, 2024 23:54
@ntruchsess
Copy link
Contributor

ntruchsess commented Nov 13, 2024

@tfjanjua as there was a conflict with latest seeding-data related changes on main I did rebase the branch on main and did a force-push to your repo. Please pull those changes before applying further commits.

@evegufy evegufy added the merge postponed the merge of this PR shall be postponed until all prerequisites are fulfilled label Dec 13, 2024
@evegufy
Copy link
Contributor

evegufy commented Dec 13, 2024

don't merge until change from BDRS side is clarified.
I was then also under the impression that you prediscussed the change with the BDRS committers, as commented here, but that doesn't seem the case, see eclipse-tractusx/bpn-did-resolution-service#120.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request merge postponed the merge of this PR shall be postponed until all prerequisites are fulfilled
Projects
Status: IN REVIEW
Development

Successfully merging this pull request may close these issues.

4 participants