Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(offerSubscription): change role (#69) #1110

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tfjanjua
Copy link
Contributor

@tfjanjua tfjanjua commented Oct 23, 2024

Description

Roles subscribe_apps and subscribe_service has been changed to view_subscription and view_service_subscriptions on following APIs:

GET: /api/apps/{appId}/subscription/{subscriptionId}/subscriber
GET: /api/services/{serviceId}/subscription/{subscriptionId}/subscriber

Why

App & service subscription details CTA leads to 403 error.

image

Issue

Ref: #987

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have checked that new and existing tests pass locally with my changes

@tfjanjua tfjanjua self-assigned this Oct 23, 2024
@tfjanjua tfjanjua added the bug Something isn't working label Oct 23, 2024
Copy link

@evegufy evegufy changed the title fix(offerSubscription): role changed (#69) fix(offerSubscription): change role change (#69) Oct 24, 2024
@evegufy evegufy changed the title fix(offerSubscription): change role change (#69) fix(offerSubscription): change role (#69) Oct 24, 2024
@ntruchsess
Copy link
Contributor

ntruchsess commented Nov 14, 2024

@tfjanjua : technically the changes look fine. Please create a corresponding issue and link within this PR
EDIT - please ignore, I somehow missed that the PR is already linked to an issue. We should first clarify the details there before deciding to merge.

@ybidois
Copy link

ybidois commented Nov 19, 2024

@ntruchsess @tfjanjua any updates on this? It's been pending for a month.

@tfjanjua
Copy link
Contributor Author

@tfjanjua : technically the changes look fine. Please create a corresponding issue and link within this PR EDIT - please ignore, I somehow missed that the PR is already linked to an issue. We should first clarify the details there before deciding to merge.

@ybidois, as per @ntruchsess's comment, we are waiting for the clarifications. Please follow the link for more details.
#987 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: IN REVIEW
Development

Successfully merging this pull request may close these issues.

3 participants