Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(connector): only provider should update connector #1086

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(connector): only provider should update connector #1086

wants to merge 5 commits into from

Conversation

dhiren-singh-007
Copy link
Contributor

@dhiren-singh-007 dhiren-singh-007 commented Oct 21, 2024 •
edited
Loading

Description

Updated the validation on update connector api so that only provider can update the connector

Why

Currently it was not possible for provider to update the connector url which provided by themself only

Issue

#1085

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes

@MaximilianHauer MaximilianHauer added this to the Release 24.12 milestone Oct 22, 2024
@Phil91 Phil91 self-assigned this Oct 24, 2024
@Phil91 Phil91 changed the base branch from main to release/v2.3.0-RC2 October 25, 2024 05:45
@dhiren-singh-007 dhiren-singh-007 removed the request for review from ntruchsess November 13, 2024 12:34
@dhiren-singh-007 dhiren-singh-007 force-pushed the bugfix/1085-fix-update-connector-validation branch from f9fb169 to 093b3a2 Compare November 13, 2024 13:13
@evegufy evegufy changed the base branch from release/v2.3.0-RC2 to main November 13, 2024 14:43
@evegufy evegufy changed the base branch from main to release/v2.3.0-RC2 November 13, 2024 14:44
@evegufy evegufy changed the base branch from release/v2.3.0-RC2 to main November 14, 2024 07:18
@dhiren-singh-007 dhiren-singh-007 force-pushed the bugfix/1085-fix-update-connector-validation branch from 093b3a2 to 22f4b07 Compare November 14, 2024 09:51
ntruchsess

This comment was marked as resolved.

Sign in to view

@ntruchsess ntruchsess linked an issue Nov 14, 2024 that may be closed by this pull request
Only provider should be able to update the connector url #1085
Open
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@evegufy
Copy link
Contributor

evegufy commented Dec 13, 2024

@ntruchsess @Phil91 please re-review

Phil91
Phil91 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@Phil91 Phil91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phil91 Phil91 Phil91 approved these changes

@ntruchsess ntruchsess Awaiting requested review from ntruchsess

Requested changes must be addressed to merge this pull request.

Assignees

@Phil91 Phil91

Labels
None yet
Projects
Portal
Status: IN PROGRESS
Milestone
Release 25.03
Development

Successfully merging this pull request may close these issues.

Only provider should be able to update the connector url
5 participants
@dhiren-singh-007 @evegufy @ntruchsess @Phil91 @MaximilianHauer