feat(check): additional checks for OPERATOR and confirmed status added in document request endpoint #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phil91
requested changes
Oct 15, 2024
src/registration/Registration.Service/BusinessLogic/RegistrationBusinessLogic.cs
Outdated
Show resolved
Hide resolved
tests/registration/Registration.Service.Tests/BusinessLogic/RegistrationBusinessLogicTest.cs
Show resolved
Hide resolved
AnuragNagpure
force-pushed
the
feature/1070-create-dedicated-endpoints-add-requests-users
branch
from
c1559a4 to
efacefb
Compare
AnuragNagpure
force-pushed
the
feature/1070-create-dedicated-endpoints-add-requests-users
branch
from
efacefb to
dcbe4ef
Compare
|
Phil91
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the endpoint GET: /api/registration/documents/{documentId} only response the document for the user which has uploaded the document. This check should be adjusted with adding check of OPERATOR and company application status confirmed.
Why
These additional check required for getting document to particular user satisfies the check condition.
Issue
Link to Github issue.
#1070
Please delete options that are not relevant.