Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate "subscriptionID" field in GET /owncompany/serviceaccounts/{serviceAccountId} endpoint #897

Closed
jjeroch opened this issue Aug 4, 2024 · 2 comments
Assignees
Labels
breaking change PR shall be handled with extra care as it breaks existing functionality bug Something isn't working

Comments

@jjeroch
Copy link
Contributor

jjeroch commented Aug 4, 2024

Environment:

  • URL: /api/administration/serviceaccount/owncompany/serviceaccounts/{serviceAccountId}
  • Release Version: unclear; likely since several releases

Description:
When calling the GET /api/administration/serviceaccount/owncompany/serviceaccounts/{serviceAccountId} endpoint, the response includes the "subscriptionID" field twice. According to the swagger documentation, "subscriptionID" should only appear once in the response.

Steps to Reproduce:

  1. Authenticate with the necessary permissions to access the admin endpoint.
  2. Send a GET request to /api/administration/serviceaccount/owncompany/serviceaccounts/{serviceAccountId} with a valid {serviceAccountId}.
  3. Observe the response.

Expected Result:
The response JSON should contain the "subscriptionID" field only once.

Actual Result:
The response JSON contains the "subscriptionID" field twice.

User Impact:
The duplicated field may cause confusion and potentially lead to issues with systems or clients that consume this API and expect the response format to match the documentation.

@jjeroch jjeroch added the bug Something isn't working label Aug 4, 2024
@jjeroch jjeroch added this to Portal Aug 4, 2024
@github-project-automation github-project-automation bot moved this to NEW USER REQUEST in Portal Aug 4, 2024
@jjeroch jjeroch moved this from NEW USER REQUEST to BACKLOG in Portal Aug 4, 2024
@jjeroch jjeroch added the breaking change PR shall be handled with extra care as it breaks existing functionality label Aug 4, 2024
@jjeroch
Copy link
Contributor Author

jjeroch commented Aug 4, 2024

Problem: this could be breaking

@Phil91 Phil91 moved this from BACKLOG to IN REVIEW in Portal Sep 2, 2024
@Phil91 Phil91 moved this from IN REVIEW to BACKLOG in Portal Sep 2, 2024
Phil91 added a commit that referenced this issue Sep 2, 2024
@Phil91 Phil91 self-assigned this Sep 2, 2024
@Phil91 Phil91 moved this from BACKLOG to IN PROGRESS in Portal Sep 2, 2024
@MaximilianHauer MaximilianHauer added this to the Release 24.12 milestone Sep 5, 2024
Phil91 added a commit that referenced this issue Sep 13, 2024
ntruchsess pushed a commit that referenced this issue Sep 16, 2024
@gopalreddy-bmw
Copy link

gopalreddy-bmw commented Oct 21, 2024

Hi @Phil91 ,@MaximilianHauer
tested this US According to the requirements it's working fine.
Attached screenshots for references:
image

@github-project-automation github-project-automation bot moved this from IN REVIEW to USER READY in Portal Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change PR shall be handled with extra care as it breaks existing functionality bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

4 participants