Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sig#796: Connector registration fails if clearinghouseConnectDisabled gets disabled after onboarding #887

Closed
Tracked by #796
evegufy opened this issue Jul 30, 2024 · 3 comments · Fixed by #894
Closed
Tracked by #796
Assignees
Labels
bug Something isn't working
Milestone

Comments

@evegufy
Copy link
Contributor

evegufy commented Jul 30, 2024

Current Behavior

Company got onboarded with clearinghouseConnectDisabled enabled(feature eclipse-tractusx/sig-release#796), afterwards clearinghouseConnectDisabled got disabled again, which leads to the following Unexpected condition at connector registration for this company:

{
    "type": "https://datatracker.ietf.org/doc/html/rfc7231#section-6.6.1",
    "title": "The server encountered an unexpected condition.",
    "status": 500,
    "errors": {
        "Org.Eclipse.TractusX.Portal.Backend.Administration.Service": [
            "provider company 4f13981d-580d-4e9c-afae-d02ae70a775e has no self description document"
        ]
    },
    "errorId": "71c89c4a-6ce2-4d12-b4cd-998e0678f30b",
    "details": [
        {
            "errorCode": "CONNECTOR_UNEXPECTED_NO_DESCRIPTION",
            "type": "AdministrationConnectorErrors",
            "message": "provider company {companyId} has no self description document",
            "parameters": [
                {
                    "name": "companyId",
                    "value": "4f13981d-580d-4e9c-afae-d02ae70a775e"
                }
            ]
        }
    ]
}

Expected Behavior

Registration of connector is successful and this case is covered concept-wise at eclipse-tractusx/sig-release#796

Steps To Reproduce

Detected in v2.1.0

@evegufy evegufy added the bug Something isn't working label Jul 30, 2024
@evegufy evegufy added this to Portal Jul 30, 2024
@github-project-automation github-project-automation bot moved this to NEW USER REQUEST in Portal Jul 30, 2024
@jjeroch jjeroch moved this from NEW USER REQUEST to BACKLOG in Portal Jul 30, 2024
@ntruchsess ntruchsess linked a pull request Aug 5, 2024 that will close this issue
8 tasks
@MaximilianHauer MaximilianHauer moved this from BACKLOG to IN PROGRESS in Portal Aug 5, 2024
@evegufy evegufy changed the title Connector registration fails if clearinghouseConnectDisabled gets disabled after onboarding sig#792: Connector registration fails if clearinghouseConnectDisabled gets disabled after onboarding Aug 5, 2024
@evegufy evegufy changed the title sig#792: Connector registration fails if clearinghouseConnectDisabled gets disabled after onboarding sig#796: Connector registration fails if clearinghouseConnectDisabled gets disabled after onboarding Aug 5, 2024
@evegufy evegufy added this to the Release 2.2.0 milestone Aug 5, 2024
@github-project-automation github-project-automation bot moved this from IN PROGRESS to USER READY in Portal Aug 6, 2024
@evegufy evegufy reopened this Aug 12, 2024
@evegufy
Copy link
Contributor Author

evegufy commented Aug 12, 2024

@Phil91 I tested #894 and I still get the same error message as in the issue description but with a different error code:

{
    "type": "[https://tools.ietf.org/html/rfc7231#section-6.5.8"](https://tools.ietf.org/html/rfc7231#section-6.5.8%22),
    "title": "The resorce is in conflict with the current request.",
    "status": 409,
    "errors": {
        "Org.Eclipse.TractusX.Portal.Backend.Administration.Service": [
            "provider company null has no self description document"
        ]
    },
    "errorId": "6061c7d5-5ea3-4eba-baaf-1754cfa3e7eb",
    "details": [
        {
            "errorCode": "CONNECTOR_CONFLICT_NO_DESCRIPTION",
            "type": "AdministrationConnectorErrors",
            "message": "provider company {CompanyId} has no self description document",
            "parameters": [
                {
                    "name": "companyId",
                    "value": "4f13981d-580d-4e9c-afae-d02ae70a775e"
                }
            ]
        }
    ]
}

@evegufy evegufy moved this from USER READY to BACKLOG in Portal Aug 12, 2024
@Phil91
Copy link
Member

Phil91 commented Aug 13, 2024

@evegufy in my opinion the error is correct since the admin would need to trigger the selfDescription creation for the companies that don't have the selfDescription set. but let's discuss this with @MaximilianHauer

@MaximilianHauer
Copy link

MaximilianHauer commented Aug 27, 2024

as discussed the behavior is expected and wanted.
we should not provide workarounds for the whole process after the onboarding. goal of the trigger was only to support a smooth procedure during the onboarding.

  • enable the user to finish the registration process
  • ensure that the sd documentation is retriggered to enable further functionality for the user

@MaximilianHauer MaximilianHauer closed this as not planned Won't fix, can't repro, duplicate, stale Aug 27, 2024
@github-project-automation github-project-automation bot moved this from BACKLOG to USER READY in Portal Aug 27, 2024
@MaximilianHauer MaximilianHauer moved this from USER READY to WONT DO in Portal Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants