Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registration process - Update Required attribute to allow optional for SubmitDocumentTypeIds in RegistrationSettings #828

Open
5 tasks
dhiren-singh-007 opened this issue Jul 10, 2024 · 6 comments · May be fixed by #853
Open
5 tasks

Registration process - Update Required attribute to allow optional for SubmitDocumentTypeIds in RegistrationSettings #828

dhiren-singh-007 opened this issue Jul 10, 2024 · 6 comments · May be fixed by #853
Assignees
@dhiren-singh-007 @MaximilianHauer
Labels
Improvement

Comments

@dhiren-singh-007
Copy link
Contributor

dhiren-singh-007 commented Jul 10, 2024 •
edited
Loading

Description

As an Operator, we discovered that we don’t necessarily need documents to be submitted during registration.
We manage all the documents during the sales process before the Portal registration process.
We want to make the document submission step optional.

Acceptance Criteria

  • As an operator, I can make documents both required or optional based on my environment variables
  • If optional, customers should be able to submit registration without adding documents
  • If optional, no error message is displayed when clicking the submission button
  • if required, an error message should be displayed when clicking the submission button
  • Whether optional or required, registration can be submitted on the Frontend side

Additional Information

In portal BE file src/registration/Registration.Service/BusinessLogic/RegistrationSettings.cs We have to update Required attribute to handle null or empty value for SubmitDocumentTypeIds and handle the null or blank array for this variable.
@dhiren-singh-007 dhiren-singh-007 self-assigned this Jul 10, 2024
@dhiren-singh-007 dhiren-singh-007 changed the title Registration process - Remove Required from SubmitDocumentTypeIds in RegistrationSettings Registration process - Update Required attribute to allow empty string for SubmitDocumentTypeIds in RegistrationSettings Jul 10, 2024
@dhiren-singh-007 dhiren-singh-007 changed the title Registration process - Update Required attribute to allow empty string for SubmitDocumentTypeIds in RegistrationSettings Registration process - Update Required attribute to allow optional for SubmitDocumentTypeIds in RegistrationSettings Jul 10, 2024
@ybidois
Copy link

ybidois commented Jul 11, 2024

Hello @jjeroch, can you confirm that we can make the "Submit document" step in the registration process optional?

We don't want to use it given the current Cofinity-X registration process, but it is required by the Portal backend.

Please give us a thumbs up so our teams can start collaborating on the technical solution!

@ybidois
Copy link

ybidois commented Jul 11, 2024

Acceptance Criteria

@dhiren-singh-007 Can you add the suggestion of @evegufy to the acceptance criteria?

  • Whether optional or required, registration can be submitted on the Frontend side

@dhiren-singh-007
Copy link
Contributor Author

Hi @ntruchsess : Did you get a chance to look into this ?

@jjeroch
Copy link
Contributor

jjeroch commented Jul 17, 2024

The ticket is getting analysed internally now. Feedback will be provided shortly. Please also share if you contribute to this ticket with code or not. This is currently not clear. If you contribute, please share already your idea to solve the issue.

@jjeroch jjeroch added this to Portal Jul 17, 2024
@github-project-automation github-project-automation bot moved this to NEW USER REQUEST in Portal Jul 17, 2024
@dhiren-singh-007
Copy link
Contributor Author

Thanks @jjeroch for the update. I am happy to contribute .I will share the PR.

@dhiren-singh-007 dhiren-singh-007 linked a pull request Jul 19, 2024 that will close this issue
Open
4 tasks
@dhiren-singh-007
Copy link
Contributor Author

@jjeroch @ntruchsess : Can you please check this PR .
#853
I also analyzed if any api will be obsolete if we enable this flag.
I found that there is no api using the flag SubmitDocumentTypeIds . All document api are generic and expecting the different parameters only.

@ntruchsess ntruchsess linked a pull request Jul 30, 2024 that will close this issue
feat(registration): make submit document type validation optional #853
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhiren-singh-007 dhiren-singh-007

@MaximilianHauer MaximilianHauer

Labels
Improvement
Projects
Portal
Status: NEW USER REQUEST
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(registration): make submit document type validation optional dhiren-singh-007/portal-backend
4 participants
@ybidois @jjeroch @dhiren-singh-007 @MaximilianHauer