Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sig#796: Ensure Application Status Endpoints Reflect Clearinghouse Feature Toggle Effects #837

Closed
Tracked by #796
jjeroch opened this issue Jul 15, 2024 · 4 comments
Closed
Tracked by #796

sig#796: Ensure Application Status Endpoints Reflect Clearinghouse Feature Toggle Effects #837

jjeroch opened this issue Jul 15, 2024 · 4 comments
Assignees
@Phil91
Labels
enhancement New feature or request
Milestone
Release 2.2.0

Comments

@jjeroch
Copy link
Contributor

jjeroch commented Jul 15, 2024

Description:

Following the implementation changes detailed in issue #792, this ticket addresses the need to verify and potentially update how the application status endpoints are functioning. The recent addition of the feature toggle to enable or disable Clearinghouse connectivity for Self-Description (SD) processes requires that the endpoints accurately reflect the state of each application process step.

Objectives:

  • Verify the behavior of the GET application status endpoints after the toggle changes.
  • Update the status representation in the endpoints to appropriately reflect the skipping or non-applicability of steps due to the feature toggle being enabled or disabled.
  • Include a comment or notation within the status to explain the reason for any skipped steps to maintain transparency and support auditing requirements.

Acceptance Criteria:

  • Endpoint Verification: The GET application status endpoints must be thoroughly tested to ensure they are behaving as expected after the toggle implementation.
  • Status Updates: If the clearinghouse connectivity is disabled, the endpoints should indicate the affected steps as "n/a" (not applicable) or equivalent, rather than omitting them.
  • Audit Support: Each step that is skipped due to the toggle being enabled should include a comment detailing the reason, aiding in clarity and audit trails.
  • Documentation: Ensure that endpoint documentation is updated to reflect the new status representations and the logic behind any changes.
@jjeroch jjeroch added the enhancement New feature or request label Jul 15, 2024
@jjeroch jjeroch added this to the Release 2.1.0 (24.08) milestone Jul 15, 2024
@jjeroch jjeroch added this to Portal Jul 15, 2024
@github-project-automation github-project-automation bot moved this to NEW USER REQUEST in Portal Jul 15, 2024
@jjeroch jjeroch moved this from NEW USER REQUEST to BACKLOG in Portal Jul 15, 2024
@jjeroch jjeroch moved this from BACKLOG to NEW USER REQUEST in Portal Jul 15, 2024
@jjeroch jjeroch mentioned this issue Jul 15, 2024
Closed
9 tasks
@jjeroch jjeroch moved this from NEW USER REQUEST to BACKLOG in Portal Jul 15, 2024
Phil91 added a commit that referenced this issue Jul 18, 2024
@Phil91
feat(clearinghouse): add comments to process step and application che…
94de1eb 
…cklist

enhance application checklist with a comment of the skipped self description step

Refs: #837
@Phil91 Phil91 mentioned this issue Jul 18, 2024
Merged
8 tasks
@Phil91 Phil91 moved this from BACKLOG to IN PROGRESS in Portal Jul 18, 2024
@jjeroch jjeroch mentioned this issue Jul 21, 2024
Closed
@jjeroch
Copy link
Contributor Author

jjeroch commented Jul 22, 2024

Refinement ongoing: application_checklist status "Skipped" likely needed

@jjeroch
Copy link
Contributor Author

jjeroch commented Jul 22, 2024

Moved to next (interim release) 24.08. closed
New sprint: 02

Phil91 added a commit that referenced this issue Jul 26, 2024
@Phil91
feat(clearinghouse): add comments to process step and application che…
fa92c16 
…cklist

enhance application checklist with a comment of the skipped self description step

Refs: #837
@evegufy evegufy modified the milestones: Release 24.12, Release 2.2.0 Aug 5, 2024
Phil91 added a commit that referenced this issue Aug 6, 2024
@Phil91
feat(clearinghouse): add comments to process step and application che…
c173961 
…cklist

enhance application checklist with a comment of the skipped self description step

Refs: #837
Phil91 added a commit that referenced this issue Aug 6, 2024
@Phil91
feat(sdFactory): adjust retrigger of sd checklist step
83a5bf6 
Refs: #837
Phil91 added a commit to eclipse-tractusx/portal that referenced this issue Aug 6, 2024
@Phil91
feat(sdFactory): add clearinghouseConnectDisabled to config
b5caed1 
Refs: eclipse-tractusx/portal-backend#837
@Phil91 Phil91 mentioned this issue Aug 6, 2024
Merged
4 tasks
Phil91 added a commit that referenced this issue Aug 6, 2024
@Phil91
feat(sdFactory): adjust retrigger of sd checklist step
125577b 
Refs: #837
Phil91 added a commit that referenced this issue Aug 6, 2024
@Phil91
feat(clearinghouse): add comments to process step and application che…
9f35954 
…cklist

enhance application checklist with a comment of the skipped self description step

Refs: #837
Phil91 added a commit that referenced this issue Aug 6, 2024
@Phil91
feat(sdFactory): adjust retrigger of sd checklist step
5d6170f 
Refs: #837
Phil91 added a commit that referenced this issue Aug 6, 2024
@Phil91
feat(sdFactory): adjust retrigger of sd checklist step
4dcd766 
Refs: #837
Phil91 added a commit that referenced this issue Aug 6, 2024
@Phil91
feat(sdFactory): adjust retrigger of sd checklist step
dbb0317 
Refs: #837
Phil91 added a commit that referenced this issue Aug 6, 2024
@Phil91
feat(sdFactory): adjust retrigger of sd checklist step
34dc57e 
Refs: #837
Phil91 added a commit that referenced this issue Aug 6, 2024
@Phil91
feat: adjust checklist entry check
3587128 
Refs: #837
Phil91 added a commit that referenced this issue Aug 6, 2024
@Phil91
feat: add clearinghouseConnectDisabled to appsettings
51834cb 
Refs: #837
Phil91 added a commit that referenced this issue Aug 7, 2024
@Phil91
feat(clearinghouse): add comments to process step and application che…
4dea66d 
…cklist (#847)

* enhance application checklist with a comment of the skipped self description step
* adjust selfDescription retriever to check if clearinghouseConnect is disabled
--------------------
Reviewed-By: Evelyn Gurschler <[email protected]>
Reviewed-By: Norbert Truchsess <[email protected]>
Refs: #837
Phil91 added a commit to eclipse-tractusx/portal that referenced this issue Aug 7, 2024
@Phil91
feat(sdFactory): add clearinghouseConnectDisabled to config (#400)
8a604f7 
Refs: eclipse-tractusx/portal-backend#837
Reviewed-By: Evelyn Gurschler <[email protected]>
@MaximilianHauer
Copy link

@Phil91 could you adjust the following documentation based on our adjustments ? https://github.com/eclipse-tractusx/portal-assets/blob/main/docs/user/01.%20Onboarding/03.%20Registration%20Approval/03.%20Registration%20Approval%20Process.md

Phil91 added a commit to eclipse-tractusx/portal-assets that referenced this issue Aug 23, 2024
@Phil91
docs: adjust documentation for registration approval process
549e12c 
Refs: eclipse-tractusx/portal-backend#837
@Phil91 Phil91 mentioned this issue Aug 23, 2024
Merged
9 tasks
@MaximilianHauer
Copy link

tested and approved

@github-project-automation github-project-automation bot moved this from IN REVIEW to USER READY in Portal Sep 4, 2024
evegufy pushed a commit to eclipse-tractusx/portal-assets that referenced this issue Sep 11, 2024
@Phil91
docs: adjust documentation for registration approval process (#391)
572a47c 
Refs: eclipse-tractusx/portal-backend#837
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Phil91 Phil91

Labels
enhancement New feature or request
Projects
Portal
Archived in project
Milestone
Release 2.2.0
Development

No branches or pull requests
4 participants
@Phil91 @evegufy @jjeroch @MaximilianHauer