Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration API Enhancement by property "registrationType" #477

Closed
6 tasks done
Tracked by #295
jjeroch opened this issue Feb 1, 2024 · 0 comments · Fixed by #481
Closed
6 tasks done
Tracked by #295

Registration API Enhancement by property "registrationType" #477

jjeroch opened this issue Feb 1, 2024 · 0 comments · Fixed by #481
Assignees
Labels
priority PR needs to prioritized at review

Comments

@jjeroch
Copy link
Contributor

jjeroch commented Feb 1, 2024

Summary

To enable the correct user direction for company accounts in the process of registration; the registration service endpoint GET /api/registration/applications must get enhanced by a new property.
 

Detail

Enhance the endpoint
GET /api/registration/applications
with the property "applicationType" to display the application type label which is either "INTERNAL" or "EXTERNAL"

New Response Body

[
  {
    "applicationId": "3fa85f64-5717-4562-b3fc-2c963f66afa6",
    "applicationStatus": "CREATED",
    "applicationType": "{company_applications.company_application_type_id}",
    "applicationChecklist": [
      {
        "typeId": "REGISTRATION_VERIFICATION",
        "statusId": "TO_DO"
      }
    ]
  }
]

 

Validation:

n/a - no change

Acceptance Criteria

  • local development done
  • unit test updated and successfully executed
  • pr created
  • pr review done
  • deployed to dev
  • tested on dev
@jjeroch jjeroch added enhancement New feature or request and removed enhancement New feature or request labels Feb 1, 2024
@jjeroch jjeroch added this to Portal Feb 1, 2024
@github-project-automation github-project-automation bot moved this to NEW USER REQUEST in Portal Feb 1, 2024
@jjeroch jjeroch moved this from NEW USER REQUEST to BACKLOG in Portal Feb 1, 2024
@jjeroch jjeroch added the priority PR needs to prioritized at review label Feb 1, 2024
@jjeroch jjeroch added this to the Version CX Release 24.03 milestone Feb 2, 2024
Phil91 added a commit to catenax-ng/tx-portal-backend that referenced this issue Feb 3, 2024
adjust endpoint GET /api/registration/applications to response the registrationType as well

Refs: eclipse-tractusx#477
@Phil91 Phil91 linked a pull request Feb 3, 2024 that will close this issue
8 tasks
@Phil91 Phil91 moved this from BACKLOG to IN PROGRESS in Portal Feb 3, 2024
ntruchsess pushed a commit that referenced this issue Feb 3, 2024
adjust endpoint GET /api/registration/applications to response the registrationType as well
Refs: #477
@ntruchsess ntruchsess moved this from IN PROGRESS to IN REVIEW in Portal Feb 3, 2024
@ntruchsess ntruchsess moved this from IN REVIEW to IN PROGRESS in Portal Feb 3, 2024
@Phil91 Phil91 moved this from IN PROGRESS to IN REVIEW in Portal Feb 5, 2024
@jjeroch jjeroch moved this from IN REVIEW to USER READY in Portal Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority PR needs to prioritized at review
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants