Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!(policies): Policies from policy hub #79

Merged
merged 4 commits into from
Mar 21, 2024

Conversation

ajithsimons
Copy link
Contributor

@ajithsimons ajithsimons commented Mar 19, 2024

Description

  • Policies will be dynamically fetched from policy hub based on the selected/available use cases in SDE.
  • Frontend components will be dynamically rendered based on the policy type.
  • Re-usable loading handlers for api calls

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@ajithsimons
Copy link
Contributor Author

Merge before #80

Copy link
Contributor

@sachinargade123 sachinargade123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sachinargade123 sachinargade123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajithsimons if we don't want to release this list of changes, Can you create un-realese section in change log and mentioned all the changes?

@ajithsimons
Copy link
Contributor Author

@ajithsimons if we don't want to release this list of changes, Can you create un-realese section in change log and mentioned all the changes?

Creating a PR for changelog and docs changes separately.

@adityagajbhiye9 adityagajbhiye9 self-requested a review March 21, 2024 04:08
Copy link
Contributor

@adityagajbhiye9 adityagajbhiye9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@almadigabor almadigabor merged commit 1682aa0 into eclipse-tractusx:main Mar 21, 2024
4 checks passed
@almadigabor almadigabor deleted the feature/dynamic_policy branch March 21, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants