-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): docs and change log updated #64
Conversation
Pls merge after #63 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please take a look at this TRG and adjust your images accordingly. |
@adityagajbhiye9 Pls look in this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ajithsimons we need to save image in .svg format.
https://eclipse-tractusx.github.io/docs/release/trg-1/trg-1-4/#description
please have a look above URL
@AjayRaturi123 pls look into this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@sachinargade123 please review |
@almadigabor SVG images updated! Pls have a look. |
Looks good, but I still have 2 remarks to consider:
|
@almadigabor Argocd reference removed from documents. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
merge before #65 |
@almadigabor could you please review this and other open PRs? Thanks! |
Description
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: