Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): docs and change log updated #64

Merged
merged 7 commits into from
Feb 16, 2024

Conversation

ajithsimons
Copy link
Contributor

@ajithsimons ajithsimons commented Feb 7, 2024

Description

  • Change log updated
  • Docs updated
  • PNG and other format images converted into SVG format

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@ajithsimons
Copy link
Contributor Author

Pls merge after #63

Copy link
Contributor

@adityagajbhiye9 adityagajbhiye9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajithsimons ajithsimons changed the title chore: change log updated chore(docs): docs and change log updated Feb 8, 2024
@almadigabor
Copy link
Contributor

Please take a look at this TRG and adjust your images accordingly.

@ajithsimons
Copy link
Contributor Author

@adityagajbhiye9 Pls look in this.

Copy link
Contributor

@adityagajbhiye9 adityagajbhiye9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajithsimons we need to save image in .svg format.
https://eclipse-tractusx.github.io/docs/release/trg-1/trg-1-4/#description
please have a look above URL

@adityagajbhiye9 adityagajbhiye9 self-requested a review February 12, 2024 09:30
@ajithsimons
Copy link
Contributor Author

@AjayRaturi123 pls look into this!

Copy link
Contributor

@adityagajbhiye9 adityagajbhiye9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adityagajbhiye9
Copy link
Contributor

@sachinargade123 please review

@ajithsimons
Copy link
Contributor Author

@almadigabor SVG images updated! Pls have a look.

@almadigabor
Copy link
Contributor

Looks good, but I still have 2 remarks to consider:

  • The documentation contains ArgoCD description which in my opinion does not make much sense in open source as we use ArgoCD in specific environments only.
  • You could reference the move from png to svc in the PR description/changelog

@AjayRaturi123
Copy link
Contributor

@almadigabor Argocd reference removed from documents.

Copy link
Contributor

@sachinargade123 sachinargade123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@adityagajbhiye9
Copy link
Contributor

merge before #65

@ajithsimons
Copy link
Contributor Author

@almadigabor could you please review this and other open PRs?

Thanks!

@almadigabor almadigabor merged commit 7d5458a into eclipse-tractusx:main Feb 16, 2024
4 checks passed
@almadigabor almadigabor deleted the docs/changelog branch February 16, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants