Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(policies): setup for policy hub #61

Merged
merged 5 commits into from
Feb 8, 2024
Merged

update(policies): setup for policy hub #61

merged 5 commits into from
Feb 8, 2024

Conversation

ajithsimons
Copy link
Contributor

@ajithsimons ajithsimons commented Feb 7, 2024 •
edited
Loading

Description

  • setup for policy hub

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@ajithsimons ajithsimons self-assigned this Feb 7, 2024
@ajithsimons
Copy link
Contributor Author

Merge this after #59

@ajithsimons ajithsimons mentioned this pull request Feb 7, 2024
Merged
2 tasks
sachinargade123
sachinargade123 approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@sachinargade123 sachinargade123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

adityagajbhiye9
adityagajbhiye9 approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@adityagajbhiye9 adityagajbhiye9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sachinargade123
sachinargade123 approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@sachinargade123 sachinargade123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

almadigabor
almadigabor requested changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@almadigabor almadigabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be aware of the license header years! If you create a new file, just put the current year in it. For other (modified) files you can either have 1 year (creation year) (e.g. 2024) or a 2 year range (creation year and last modification year) with commas separated (e.g. 2019,2024)

adityagajbhiye9
adityagajbhiye9 suggested changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@adityagajbhiye9 adityagajbhiye9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajithsimons Please check copy right

@adityagajbhiye9
Copy link
Contributor

@ajithsimons

Please be aware of the license header years! If you create a new file, just put the current year in it. For other (modified) files you can either have 1 year (creation year) (e.g. 2024) or a 2 year range (creation year and last modification year) with commas separated (e.g. 2019,2024)

Asked team to update Thanks.

adityagajbhiye9
adityagajbhiye9 suggested changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@adityagajbhiye9 adityagajbhiye9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajithsimons Please check this one.

@ajithsimons
Copy link
Contributor Author

@adityagajbhiye9 @almadigabor updated the copyright headers. will follow the same for other PRs as well. Thanks for the info!

adityagajbhiye9
adityagajbhiye9 approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@adityagajbhiye9 adityagajbhiye9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

almadigabor
almadigabor approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@almadigabor almadigabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@almadigabor almadigabor merged commit 6be2289 into eclipse-tractusx:main Feb 8, 2024
4 checks passed
@almadigabor almadigabor deleted the feature/policy_hub branch February 8, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityagajbhiye9 adityagajbhiye9 adityagajbhiye9 approved these changes

@sachinargade123 sachinargade123 sachinargade123 approved these changes

@almadigabor almadigabor almadigabor approved these changes

Assignees

@ajithsimons ajithsimons

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ajithsimons @adityagajbhiye9 @almadigabor @sachinargade123