Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix|sde-backend] : Fix Open api doc for KICS #99

Closed
wants to merge 3 commits into from
Closed

[fix|sde-backend] : Fix Open api doc for KICS #99

wants to merge 3 commits into from

Conversation

sachinargade123
Copy link
Contributor

@sachinargade123 sachinargade123 commented Feb 21, 2024 •
edited
Loading

Description

Fixed

  • Open API docs update for kics fix

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

sachinargade123 and others added 3 commits February 21, 2024 11:05
@sachinargade123
open api doc update
8580413
@sachinargade123
Merge pull request #277 from catenax-ng/main
a439c6a 
sync to latest code
@adityagajbhiye9
open-api.yaml fixed for kics
27337e9 
- open-api.yaml fixed with Array Maximum Number of Items (v3).
@adityagajbhiye9
Copy link
Contributor

adityagajbhiye9 commented Feb 21, 2024 •
edited
Loading

@amoldashwant Please review and approve.

dvasunin
dvasunin approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@dvasunin dvasunin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I am approving it, are you sure 3 is enough for an array? I usually use a big number in similar situation, e.g. 512 or higher.

adityagajbhiye9
adityagajbhiye9 approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@adityagajbhiye9 adityagajbhiye9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sachinargade123
Copy link
Contributor Author

Closing this PR. The suggested changes are available with #100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityagajbhiye9 adityagajbhiye9 adityagajbhiye9 approved these changes

@dvasunin dvasunin dvasunin approved these changes

@almadigabor almadigabor Awaiting requested review from almadigabor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sachinargade123 @adityagajbhiye9 @dvasunin