Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix|sde-backend] Docker Image changed #88

Merged
merged 3 commits into from
Feb 19, 2024
Merged

[Fix|sde-backend] Docker Image changed #88

merged 3 commits into from
Feb 19, 2024

Conversation

adityagajbhiye9
Copy link
Contributor

@adityagajbhiye9 adityagajbhiye9 commented Feb 14, 2024 •
edited
Loading

Description

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@adityagajbhiye9
[Fix|sde-backend] Docker Image changed
cbdc1a4 
- Docker image changed to fix vulnerability.
@adkumar1
Copy link
Contributor

Looks good

sachinargade123
sachinargade123 approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@sachinargade123 sachinargade123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adityagajbhiye9
Updated changelog
df9bb3e 
Docker image changed updated.
@adkumar1
Copy link
Contributor

Looks good

dvasunin
dvasunin approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@dvasunin dvasunin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adityagajbhiye9
Copy link
Contributor Author

merge after #87

@adityagajbhiye9 adityagajbhiye9 removed the request for review from almadigabor February 16, 2024 09:41
tomaszbarwicki
tomaszbarwicki requested changes Feb 16, 2024
View reviewed changes
build/Dockerfile Outdated Show resolved Hide resolved
almadigabor
almadigabor approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@almadigabor almadigabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adityagajbhiye9
Copy link
Contributor Author

@tomaszbarwicki Please review and merge the PR. Changes has been done.

@almadigabor almadigabor merged commit 235a6db into eclipse-tractusx:main Feb 19, 2024
3 checks passed
@almadigabor almadigabor deleted the rel-24.03-imagefix branch February 19, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almadigabor almadigabor almadigabor approved these changes

@adkumar1 adkumar1 adkumar1 approved these changes

@sachinargade123 sachinargade123 sachinargade123 approved these changes

@dvasunin dvasunin dvasunin approved these changes

@tomaszbarwicki tomaszbarwicki Awaiting requested review from tomaszbarwicki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@adityagajbhiye9 @adkumar1 @dvasunin @tomaszbarwicki @almadigabor @sachinargade123