Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix]: SDE backend : PCF schema update with security issue fixed #74

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

sachinargade123
Copy link
Contributor

@sachinargade123 sachinargade123 commented Nov 27, 2023

Description

Fixed

  • Update PCF schema fields for SDE
  • trivy worklow fix.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@adityagajbhiye9
Copy link
Contributor

@FaGru3n Please merge this PR before #75 PR.

@FaGru3n
Copy link
Contributor

FaGru3n commented Nov 28, 2023

Hi @adityagajbhiye9 and @sachinargade123

thanks for splitting your huge PR.

Just to remind you as part of the System Team i can not validate the content and the functionality against it.

I can only rely on your testing strategy and your knowledge how your product works. Also as followed our TRG´s you can also have a quick info what to ensure in your product. https://eclipse-tractusx.github.io/docs/release

I would also recommend the idea to have at least one committer in your product team. So please checkout also our guideline how to become a committer in our Eclipse project. https://eclipse-tractusx.github.io/docs/oss/contributor-committer#committer

As a general reminder following conventional commits https://www.conventionalcommits.org/en/v1.0.0/ it is not recommended to use fixes and features in one PR could be missleading and could break your features.

Unless for upcomming release it is nessesary i know ... but keep in mind that you have to work against Eclipse Tractus X GitHub organisation not Catena-X GitHub Orga... (this is the reason to have a committer in your round)

@FaGru3n FaGru3n requested a review from hzierer November 28, 2023 08:36
@sachinargade123
Copy link
Contributor Author

sachinargade123 commented Nov 28, 2023

@FaGru3n
Thanks for information.
Let me asked from my team @dvasunin to review this PR.

@FaGru3n
Copy link
Contributor

FaGru3n commented Nov 28, 2023

@FaGru3n Thanks for information. Let me asked from my team @dvasunin to review this PR.

i guess @dvasunin is only a contributor and can also not merge your PR

@FaGru3n FaGru3n requested a review from dvasunin November 28, 2023 09:13
@FaGru3n
Copy link
Contributor

FaGru3n commented Nov 28, 2023

Best Idea is that someone who can verify the content updates the PR´s and if no committer in your team is available, we can merge it but we have to trust your changes, so please keep aware of that.

@hzierer
Copy link
Contributor

hzierer commented Nov 28, 2023

can you please add to the description why you want to downgrade Java 18 -> 17?

@hzierer
Copy link
Contributor

hzierer commented Nov 28, 2023

Apart from that the PR LGTM.

Nevertheless it can't be merged until @adityagajbhiye9 has signed the ECA. (automatic check will fail)

@FaGru3n FaGru3n requested a review from dvasunin November 28, 2023 10:09
@dvasunin
Copy link
Contributor

LGTM

@FaGru3n
Copy link
Contributor

FaGru3n commented Nov 28, 2023

LGTM

thanks for commenting the issue with your statement, but i would kindly ask if you can review the PR with an approval in the code section and then there is a "approve" option.
as shown in #74 (comment)

Copy link
Contributor

@dvasunin dvasunin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adityagajbhiye9
Copy link
Contributor

can you please add to the description why you want to downgrade Java 18 -> 17?
It has been downgraded to 17 due to vulnerabilities in image eclipse-temurin:18 &19. So we decided to use java 17 image which doesn't contain high/critical vulnerabilities.

pom.xml Show resolved Hide resolved
Copy link
Contributor

@hzierer hzierer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment below. Rest LGTM

@FaGru3n FaGru3n merged commit d370bdc into eclipse-tractusx:main Nov 28, 2023
3 checks passed
@FaGru3n FaGru3n deleted the hotfix_3.2_with_pcf_part_1 branch November 28, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants