Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : Dependabot bump issues fix #202

Merged

Conversation

ChetanT-System
Copy link
Contributor

@ChetanT-System ChetanT-System commented Jul 11, 2024

Description

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

return objectNode;
}

public void delete(Integer rowIndex, JsonObject jsonObject, String delProcessId, String refProcessId) {

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
EDCUsecaseStep.delete
; it is advisable to add an Override annotation.
public class PCFEDCUsecaseHandler extends Step implements EDCUsecaseStep {

@SneakyThrows
public ObjectNode run(Integer rowNumber, ObjectNode objectNode, String processId, PolicyModel policy) {

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
EDCUsecaseStep.run
; it is advisable to add an Override annotation.

String resource = "pcf-v7.0.0.json";
// this is the path within the jar file
InputStream input = this.getClass().getResourceAsStream("/resources/" + resource);

Check warning

Code scanning / CodeQL

Unsafe use of getResource Warning

The idiom getClass().getResource() is unsafe for classes that may be extended.
@adityagajbhiye9
Copy link
Contributor

@almadigabor please review and merge.

Copy link
Contributor

@sachinargade123 sachinargade123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DEPENDENCIES Outdated
@@ -20,10 +20,12 @@ maven/mavencentral/com.google.code.gson/gson/2.11.0, Apache-2.0, approved, #1482
maven/mavencentral/com.google.errorprone/error_prone_annotations/2.21.1, Apache-2.0, approved, #9834
maven/mavencentral/com.google.errorprone/error_prone_annotations/2.27.0, Apache-2.0, approved, #14584
maven/mavencentral/com.jayway.jsonpath/json-path/2.9.0, Apache-2.0, approved, clearlydefined
maven/mavencentral/com.networknt/json-schema-validator/1.4.0, Apache-2.0 AND Unicode-TOU, approved, #13812
maven/mavencentral/com.networknt/json-schema-validator/1.5.0, Apache-2.0 AND LicenseRef-scancode-unicode, restricted, #15630
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency is currently being reviewed by the Eclipse Foundation IP team: https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/15630

Let's wait for it and once it's approved the DEPENDENCIES file should be updated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's been approved, you can update the file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@almadigabor almadigabor merged commit e3fdf55 into eclipse-tractusx:main Jul 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants