feat | fix : New pcf submodel v 7.0.0 support changes and security file update #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return objectNode; | ||
| } | ||
|
|
||
| public void delete(Integer rowIndex, JsonObject jsonObject, String delProcessId, String refProcessId) { |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
| public class PCFEDCUsecaseHandler extends Step implements EDCUsecaseStep { | ||
|
|
||
| @SneakyThrows | ||
| public ObjectNode run(Integer rowNumber, ObjectNode objectNode, String processId, PolicyModel policy) { |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
|
|
||
| String resource = "pcf-v7.0.0.json"; | ||
| // this is the path within the jar file | ||
| InputStream input = this.getClass().getResourceAsStream("/resources/" + resource); |
Check warning
Code scanning / CodeQL
Unsafe use of getResource Warning
|
@sachinargade123, @adityagajbhiye9 Please review and approve the PR. |
adityagajbhiye9
requested review from
sachinargade123,
adityagajbhiye9 and
almadigabor
almadigabor
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: