feat | PCF exchange code refactor and bpdm service api call changes. #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...e/src/main/java/org/eclipse/tractusx/sde/pcfexchange/service/impl/ProxyRequestInterface.java
Fixed
Show fixed
Hide fixed
modules/sde-core/src/main/java/org/eclipse/tractusx/sde/core/service/PartnerPoolService.java
Fixed
Show fixed
Hide fixed
modules/sde-core/src/main/java/org/eclipse/tractusx/sde/core/service/PartnerPoolService.java
Fixed
Show fixed
Hide fixed
|
|
||
|
|
||
| private LegalEntityData fetchLegalEntityDataByEdrToken(String bpnLs, String legalName, | ||
| String bpdmProviderEdcPublicUrl, EDRCachedByIdResponse edrToken, Integer page, Integer size) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
| @@ -159,7 +160,7 @@ | |||
|
|
|||
| @SneakyThrows | |||
| private List<QueryDataOfferModel> getSubmodelDetails(ShellLookupRequest shellLookupRequest, String endpoint, | |||
| Map<String, String> header, String dtOfferUrl, List<String> shellIds, String submodel) { | |||
| Map<String, String> header, String dtOfferUrl, List<String> shellIds, String submodel, String searchBPN) { | |||
Check notice
Code scanning / CodeQL
Useless parameter Note
adityagajbhiye9
suggested changes
May 24, 2024
...s/sde-core/src/test/java/org/eclipse/tractusx/sde/controllers/PortalProxyControllerTest.java
Outdated
Show resolved
Hide resolved
|
@almadigabor Please review and approve merge the PR. |
almadigabor
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: