feat | refactor code for correction semantic id in pcf submodel #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...e/src/main/java/org/eclipse/tractusx/sde/pcfexchange/service/impl/ProxyRequestInterface.java
Fixed
Show fixed
Hide fixed
|
|
||
| if (policy.getTechnicalKey().equals(edcAssetConfigurableConstant.getBpnNumberTechnicalKey()) | ||
| && !values.isEmpty() && !values.contains(sdeConfigurationProperties.getManufacturerId()) | ||
| && (values.size() == 1 && !values.get(0).equals(""))) { |
Check notice
Code scanning / CodeQL
Inefficient empty string test Note
|
@sachinargade123 , @amoldashwant Please review and approve the PR. |
|
@amoldashwant Please review and approve |
almadigabor
requested changes
May 21, 2024
There was a problem hiding this comment.
Please fix the license headers in all of the files in the PR. For example don't put whitespaces between the years. You can see the rules here.
|
@ChetanT-System Please check. |
@almadigabor Corrected license headers. Please review again and approve |
almadigabor
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: