Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat | Release dt access api support 1 #153

Merged

Conversation

sachinargade123
Copy link
Contributor

@sachinargade123 sachinargade123 commented May 8, 2024

Description

Added

  • Added new files for digital twin access rule support.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

shellDescriptorResponse.getSubmodelDescriptors().forEach(e ->
shellDescriptorResponse.getSubmodelDescriptors()
.stream()
.filter(ele -> createSubModelRequest == null || (createSubModelRequest != null

Check warning

Code scanning / CodeQL

Useless null check Warning

This check is useless.
createSubModelRequest
cannot be null at this check, since it is guarded by
... == ...
.
Copy link
Contributor

@adityagajbhiye9 adityagajbhiye9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sachinargade123 pushed a commit to sachinargade123/dft-backend that referenced this pull request May 9, 2024
@almadigabor almadigabor merged commit 37f08fe into eclipse-tractusx:main May 9, 2024
6 checks passed
@almadigabor almadigabor deleted the release_dt_access_api_support_1 branch May 9, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants