Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : Refactored partasplanned and SingleLevelBoMAsPlanned maven module to support multi versions #143

Merged
merged 6 commits into from
Apr 30, 2024
Merged

feat : Refactored partasplanned and SingleLevelBoMAsPlanned maven module to support multi versions #143

merged 6 commits into from
Apr 30, 2024

Conversation

ChetanT-System
Copy link
Contributor

@ChetanT-System ChetanT-System commented Apr 26, 2024 •
edited
Loading

Description

  • Refactored/Updated PartAsPlanned and SingleLevelBoMAsPlanned maven module to support multi version.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 26, 2024
View reviewed changes
...a/org/eclipse/tractusx/sde/core/processreport/repository/SubmodelCustomHistoryGenerator.java Outdated
@Modifying
@Transactional
@SneakyThrows
public int saveSubmodelData(List<String> colNames, String tableEntityName, String processId, JsonNode submodelData,

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'processId' is never used.
...ava/org/eclipse/tractusx/sde/pcfexchange/service/impl/AsyncPushPCFDataForApproveRequest.java Outdated
Comment on lines 125 to 129
JsonObject calculatedPCFValue = jsonObjectList.stream()
.filter(ele -> request.getProductId()
.equals(JsonObjectUtility.getValueFromJsonObject(ele, PRODUCT_ID)))
.findAny().orElseThrow(() -> new NoDataFoundException(
"No data found for product_id " + request.getProductId()));

Check notice

Code scanning / CodeQL

Unread local variable Note

Variable 'JsonObject calculatedPCFValue' is never read.
...ain/java/org/eclipse/tractusx/sde/core/submodel/executor/step/DigitalTwinUseCaseHandler.java Outdated
}

@SneakyThrows
public String checkShellAndGetIdIfExist(ObjectNode jsonObject, Map<String, String> specificAssetIds)

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'jsonObject' is never used.
...c/main/java/org/eclipse/tractusx/sde/core/submodel/executor/step/DatabaseUsecaseHandler.java Outdated
}

@SneakyThrows
public int getUpdatedData(String processId) {

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
DatabaseUsecaseStep.getUpdatedData
Loading
; it is advisable to add an Override annotation.
...c/main/java/org/eclipse/tractusx/sde/core/submodel/executor/step/DatabaseUsecaseHandler.java Outdated
}

@SneakyThrows
public JsonObject readCreatedTwinsDetails(String uuid) {

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
DatabaseUsecaseStep.readCreatedTwinsDetails
Loading
; it is advisable to add an Override annotation.
...bmodules/serial-part/src/main/java/org/eclipse/tractusx/sde/submodels/sp/SerialPartV300.java Fixed Show fixed Hide fixed
...-built/src/main/java/org/eclipse/tractusx/sde/submodels/slbab/SingleLevelBomAsBuiltV300.java Fixed Show fixed Hide fixed
...nformation/src/main/java/org/eclipse/tractusx/sde/submodels/pti/PartTypeInformationV100.java Fixed Show fixed Hide fixed
...s/sde-submodules/batch/src/main/java/org/eclipse/tractusx/sde/submodels/batch/BatchV300.java Fixed Show fixed Hide fixed
...nned/src/main/java/org/eclipse/tractusx/sde/submodels/slbap/SingleLevelBoMAsPlannedV300.java

String resource = "single-level-bom-as-planned-v3.0.0.json";
// this is the path within the jar file
InputStream input = this.getClass().getResourceAsStream("/resources/" + resource);

Check warning

Code scanning / CodeQL

Unsafe use of getResource Warning

The idiom getClass().getResource() is unsafe for classes that may be extended.
@ChetanT-System
Merge remote-tracking branch 'origin/CX_R24.05_batch_multi_version_su…
0d3dd63 
…pport' into CX_R24.05_part_as_planned_multi_version_support
@ChetanT-System
Merge remote-tracking branch 'origin/CX_R24.05_batch_multi_version_su…
e1f5aec 
…pport' into CX_R24.05_part_as_planned_multi_version_support
sachinargade123
sachinargade123 approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@sachinargade123 sachinargade123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

adityagajbhiye9
adityagajbhiye9 approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@adityagajbhiye9 adityagajbhiye9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChetanT-System
Copy link
Contributor Author

@almadigabor Please review and approve the PR.

@almadigabor almadigabor merged commit 257e104 into eclipse-tractusx:main Apr 30, 2024
6 checks passed
@almadigabor almadigabor deleted the CX_R24.05_part_as_planned_multi_version_support branch April 30, 2024 14:13
sachinargade123 added a commit to sachinargade123/dft-backend that referenced this pull request May 9, 2024
@sachinargade123
Merge pull request eclipse-tractusx#143 from catenax-ng/DST_PIP9_ITR3
c256af0 
Update DEPENDENCIES after IP check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityagajbhiye9 adityagajbhiye9 adityagajbhiye9 approved these changes

@sachinargade123 sachinargade123 sachinargade123 approved these changes

@almadigabor almadigabor almadigabor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChetanT-System @almadigabor @sachinargade123 @adityagajbhiye9