-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : New maven module for part type information submodel #141
feat : New maven module for part type information submodel #141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...bmodules/serial-part/src/main/java/org/eclipse/tractusx/sde/submodels/sp/SerialPartV300.java
Fixed
Show fixed
Hide fixed
...-built/src/main/java/org/eclipse/tractusx/sde/submodels/slbab/SingleLevelBomAsBuiltV300.java
Fixed
Show fixed
Hide fixed
...nformation/src/main/java/org/eclipse/tractusx/sde/submodels/pti/PartTypeInformationV100.java
Fixed
Show fixed
Hide fixed
into CX_R24.05_part_type_information
...-built/src/main/java/org/eclipse/tractusx/sde/submodels/slbab/SingleLevelBomAsBuiltV100.java
Fixed
Show fixed
Hide fixed
@almadigabor Please review and approve the PR. |
@ChetanT-System Please have a look for the CodeQL Warnings. |
@ChetanT-System Please have a look for codeql warnings as suggested by @almadigabor |
@almadigabor CodeQL warnings fixed Please review and approve the PR |
Latest code merging into ITR3-PIP9
Description
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: