Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : New maven module for part type information submodel #141

Merged

Conversation

ChetanT-System
Copy link
Contributor

@ChetanT-System ChetanT-System commented Apr 25, 2024

Description

  • Added new maven module for part type information submodel support.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link
Contributor

@sachinargade123 sachinargade123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@adityagajbhiye9 adityagajbhiye9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@almadigabor almadigabor self-requested a review April 29, 2024 13:05
@ChetanT-System
Copy link
Contributor Author

@almadigabor Please review and approve the PR.

@adityagajbhiye9
Copy link
Contributor

@ChetanT-System Please have a look for the CodeQL Warnings.

@adityagajbhiye9
Copy link
Contributor

@ChetanT-System Please have a look for codeql warnings as suggested by @almadigabor

@ChetanT-System
Copy link
Contributor Author

@ChetanT-System Please have a look for the CodeQL Warnings.

@almadigabor CodeQL warnings fixed Please review and approve the PR

@almadigabor almadigabor merged commit 7be2229 into eclipse-tractusx:main Apr 30, 2024
6 checks passed
@almadigabor almadigabor deleted the CX_R24.05_part_type_information branch April 30, 2024 08:26
sachinargade123 pushed a commit to sachinargade123/dft-backend that referenced this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants