Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : code changes for new serial part submodel with multi version and removed not supported maven modules #139

Merged
merged 13 commits into from
Apr 29, 2024
Merged

feat : code changes for new serial part submodel with multi version and removed not supported maven modules #139

merged 13 commits into from
Apr 29, 2024

Conversation

ChetanT-System
Copy link
Contributor

@ChetanT-System ChetanT-System commented Apr 25, 2024 •
edited
Loading

Description

  • Supported new serial part submodel with multi version support.
  • Removed maven modules serial-part-typization and assembly-part-relationship for update.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 25, 2024
View reviewed changes
...n/java/org/eclipse/tractusx/sde/core/submodel/executor/step/DigitalTwinLookUpInRegistry.java Outdated

@SneakyThrows
public String lookupTwinRemotely(Integer rowIndex, Map<String, String> specificAssetIds,
String bpnForRemoteRegistry, ObjectNode jsonObject, JsonObject asJsonObject) {

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'asJsonObject' is never used.
...n/java/org/eclipse/tractusx/sde/core/submodel/executor/step/DigitalTwinLookUpInRegistry.java Outdated
private final DigitalTwinsFacilitator digitalTwinFacilitator;

@SneakyThrows
public String lookupTwinInLocalRrgistry(Integer rowIndex, Map<String, String> specificAssetIds,

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'rowIndex' is never used.
...n/java/org/eclipse/tractusx/sde/core/submodel/executor/step/DigitalTwinLookUpInRegistry.java Outdated

@SneakyThrows
public String lookupTwinInLocalRrgistry(Integer rowIndex, Map<String, String> specificAssetIds,
ObjectNode jsonObject, JsonObject asJsonObject) {

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'jsonObject' is never used.
...n/java/org/eclipse/tractusx/sde/core/submodel/executor/step/DigitalTwinLookUpInRegistry.java Outdated

@SneakyThrows
public String lookupTwinInLocalRrgistry(Integer rowIndex, Map<String, String> specificAssetIds,
ObjectNode jsonObject, JsonObject asJsonObject) {

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'asJsonObject' is never used.
...n/java/org/eclipse/tractusx/sde/core/submodel/executor/step/DigitalTwinLookUpInRegistry.java Outdated

@SneakyThrows
private String getChildSubmodelDetails(Integer rowIndex, ShellLookupRequest shellLookupRequest, String endpoint,
Map<String, String> header, ObjectNode jsonObject, String dtOfferUrl, List<String> childshellIds)

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'jsonObject' is never used.
...c/main/java/org/eclipse/tractusx/sde/core/submodel/executor/step/DatabaseUsecaseHandler.java Outdated
private final SubmoduleUtility submoduleUtility;

@SneakyThrows
public JsonNode run(Integer rowIndex, ObjectNode jsonObject, String processId, PolicyModel policy) {

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
DatabaseUsecaseStep.run
Loading
; it is advisable to add an Override annotation.
...re/src/main/java/org/eclipse/tractusx/sde/core/submodel/executor/step/EDCUsecaseHandler.java Outdated
}
}

public void delete(Integer rowIndex, JsonObject jsonObject, String delProcessId, String refProcessId) {

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
EDCUsecaseStep.delete
Loading
; it is advisable to add an Override annotation.
...re/src/main/java/org/eclipse/tractusx/sde/core/submodel/executor/step/EDCUsecaseHandler.java Outdated
private final DeleteEDCFacilitator deleteEDCFacilitator;

@SneakyThrows
public ObjectNode run(Integer rowNumber, ObjectNode objectNode, String processId, PolicyModel policy) {

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
EDCUsecaseStep.run
Loading
; it is advisable to add an Override annotation.
...ain/java/org/eclipse/tractusx/sde/core/submodel/executor/step/DigitalTwinUseCaseHandler.java Outdated
}

@SneakyThrows
public JsonNode run(Integer rowIndex, ObjectNode jsonObject, String processId, PolicyModel policy) {

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
DigitalTwinUsecaseStep.run
Loading
; it is advisable to add an Override annotation.
...ain/java/org/eclipse/tractusx/sde/core/submodel/executor/step/DigitalTwinUseCaseHandler.java Outdated

private final DigitalTwinLookUpInRegistry digitalTwinLookUpInRegistry;

public void delete(Integer rowIndex, JsonObject jsonObject, String delProcessId, String refProcessId) {

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
DigitalTwinUsecaseStep.delete
Loading
; it is advisable to add an Override annotation.
sachinargade123
sachinargade123 approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@sachinargade123 sachinargade123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

adityagajbhiye9
adityagajbhiye9 approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@adityagajbhiye9 adityagajbhiye9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

almadigabor
almadigabor previously approved these changes Apr 29, 2024
View reviewed changes
@almadigabor almadigabor dismissed their stale review April 29, 2024 07:46

still verifying some stuff

@ChetanT-System
Copy link
Contributor Author

@almadigabor I have updated changelog file and PR discription about removed maven modules.

@ChetanT-System ChetanT-System changed the title feat : code changes for new serial part submodel with multi version support feat : code changes for new serial part submodel with multi version and removed not supported maven modules Apr 29, 2024
@almadigabor almadigabor merged commit ba3d3f6 into eclipse-tractusx:main Apr 29, 2024
6 checks passed
@almadigabor almadigabor deleted the CX_R24.05_multi_version_submodel_impl_part_4 branch April 29, 2024 11:23
sachinargade123 pushed a commit to sachinargade123/dft-backend that referenced this pull request May 9, 2024
@adityagajbhiye9
Merge pull request eclipse-tractusx#139 from catenax-ng/DST_PIP9_ITR2…
f1054b1 
…_A1SDS-2359_DDTR

- Empty check added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityagajbhiye9 adityagajbhiye9 adityagajbhiye9 approved these changes

@sachinargade123 sachinargade123 sachinargade123 approved these changes

@almadigabor almadigabor almadigabor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChetanT-System @almadigabor @sachinargade123 @adityagajbhiye9