Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : Draft code changes for multi submodel version support impl #135

Merged
merged 4 commits into from
Apr 25, 2024
Merged

feat : Draft code changes for multi submodel version support impl #135

merged 4 commits into from
Apr 25, 2024

Conversation

ChetanT-System
Copy link
Contributor

@ChetanT-System ChetanT-System commented Apr 24, 2024 •
edited
Loading

Description

  • Added new classes for multiple submodel version support impl.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 24, 2024
View reviewed changes
...n/java/org/eclipse/tractusx/sde/core/submodel/executor/step/DigitalTwinLookUpInRegistry.java

@SneakyThrows
public String lookupTwinRemotely(Integer rowIndex, Map<String, String> specificAssetIds,
String bpnForRemoteRegistry, ObjectNode jsonObject, JsonObject asJsonObject) {

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'asJsonObject' is never used.
...n/java/org/eclipse/tractusx/sde/core/submodel/executor/step/DigitalTwinLookUpInRegistry.java
private final DigitalTwinsFacilitator digitalTwinFacilitator;

@SneakyThrows
public String lookupTwinInLocalRrgistry(Integer rowIndex, Map<String, String> specificAssetIds,

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'rowIndex' is never used.
...n/java/org/eclipse/tractusx/sde/core/submodel/executor/step/DigitalTwinLookUpInRegistry.java

@SneakyThrows
public String lookupTwinInLocalRrgistry(Integer rowIndex, Map<String, String> specificAssetIds,
ObjectNode jsonObject, JsonObject asJsonObject) {

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'jsonObject' is never used.
...n/java/org/eclipse/tractusx/sde/core/submodel/executor/step/DigitalTwinLookUpInRegistry.java

@SneakyThrows
public String lookupTwinInLocalRrgistry(Integer rowIndex, Map<String, String> specificAssetIds,
ObjectNode jsonObject, JsonObject asJsonObject) {

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'asJsonObject' is never used.
...n/java/org/eclipse/tractusx/sde/core/submodel/executor/step/DigitalTwinLookUpInRegistry.java

@SneakyThrows
private String getChildSubmodelDetails(Integer rowIndex, ShellLookupRequest shellLookupRequest, String endpoint,
Map<String, String> header, ObjectNode jsonObject, String dtOfferUrl, List<String> childshellIds)

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'jsonObject' is never used.
...main/java/org/eclipse/tractusx/sde/core/submodel/executor/step/SubmoduleResponseHandler.java
return jsonString;
}
try {
JsonParser parser = new JsonParser();

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
JsonParser.JsonParser
Loading
should be avoided because it has been deprecated.
...main/java/org/eclipse/tractusx/sde/core/submodel/executor/step/SubmoduleResponseHandler.java
}
try {
JsonParser parser = new JsonParser();
JsonElement element = parser.parse(jsonString);

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
JsonParser.parse
Loading
should be avoided because it has been deprecated.
...main/java/org/eclipse/tractusx/sde/core/submodel/executor/step/SubmoduleResponseHandler.java
Gson gson = new Gson();

@SuppressWarnings("unchecked")
public JsonObject mapJsonbjectToFormatedResponse(JsonObject jsonObject) {

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
SubmoduleMapperUsecaseStep.mapJsonbjectToFormatedResponse
Loading
; it is advisable to add an Override annotation.
sachinargade123
sachinargade123 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@sachinargade123 sachinargade123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

adityagajbhiye9
adityagajbhiye9 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@adityagajbhiye9 adityagajbhiye9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sachinargade123
sachinargade123 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@sachinargade123 sachinargade123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChetanT-System
Copy link
Contributor Author

@almadigabor Please review and merge the PR.

@almadigabor almadigabor merged commit f4aa1cd into eclipse-tractusx:main Apr 25, 2024
6 checks passed
@almadigabor almadigabor deleted the CX_R24.05_multi-_version_submodel_support_impl branch April 25, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityagajbhiye9 adityagajbhiye9 adityagajbhiye9 approved these changes

@sachinargade123 sachinargade123 sachinargade123 approved these changes

@almadigabor almadigabor almadigabor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChetanT-System @almadigabor @sachinargade123 @adityagajbhiye9