Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] : Updated documents. #116

Merged
merged 7 commits into from
Apr 9, 2024

Conversation

ChetanT-System
Copy link
Contributor

@ChetanT-System ChetanT-System commented Apr 4, 2024

Description

Added

  • Updated readme.md and open api yml file.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@ChetanT-System ChetanT-System changed the title Cx pi12 s6 01 [doc] : Updated documents. Apr 4, 2024
README.md Outdated Show resolved Hide resolved
@ChetanT-System ChetanT-System requested a review from dvasunin April 4, 2024 11:06
README.md Show resolved Hide resolved
@ChetanT-System ChetanT-System requested a review from dvasunin April 4, 2024 12:04
Copy link
Contributor

@dvasunin dvasunin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant something like this: [Detailed API specs available here](modules/sde-core/src/main/resources/sde-open-api.yml, then a correct link is generated by MD processor, but it's ok. here is examples

@ChetanT-System
Copy link
Contributor Author

I meant something like this: [Detailed API specs available here](modules/sde-core/src/main/resources/sde-open-api.yml, then a correct link is generated by MD processor, but it's ok. here is examples

@dvasunin Updated readme.md file as you expected.

Copy link
Contributor

@sachinargade123 sachinargade123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChetanT-System
Copy link
Contributor Author

@almadigabor Please review and approve the PR.

@almadigabor almadigabor merged commit 786098e into eclipse-tractusx:main Apr 9, 2024
6 checks passed
@almadigabor almadigabor deleted the CX_PI12_S6_01 branch April 9, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants