Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat|sde-backend] : PCF exchange draft code changes #113

Merged
merged 6 commits into from
Apr 9, 2024
Merged

[feat|sde-backend] : PCF exchange draft code changes #113

merged 6 commits into from
Apr 9, 2024

Conversation

ChetanT-System
Copy link
Contributor

@ChetanT-System ChetanT-System commented Apr 1, 2024 •
edited
Loading

Description

Added

  • Added controller interface api's for Policy management.
  • External EDC service interface api updated.
  • Updated supported sub-model implementation classes.
  • EDC asset update refactored in supported submodels.
  • Support for pcf v6.0.0 submodel.
  • Added module for pcf exchange service.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 2, 2024
View reviewed changes
modules/sde-core/src/main/java/org/eclipse/tractusx/sde/core/policy/entity/PolicyMapper.java Outdated

PolicyEntity mapFrom(PolicyModel pojo);

PolicyModel mapFrom(PolicyTemplateRequest request);

Check notice

Code scanning / CodeQL

Confusing overloading of methods Note

Method PolicyMapper.mapFrom(..) could be confused with overloaded method
mapFrom
Loading
, since dispatch depends on static types.
modules/sde-core/src/main/java/org/eclipse/tractusx/sde/core/policy/entity/PolicyMapper.java Outdated

PolicyModel mapFrom(PolicyEntity entiry);

PolicyEntity mapFrom(PolicyModel pojo);

Check notice

Code scanning / CodeQL

Confusing overloading of methods Note

Method PolicyMapper.mapFrom(..) could be confused with overloaded method
mapFrom
Loading
, since dispatch depends on static types.
Method PolicyMapper.mapFrom(..) could be confused with overloaded method
mapFrom
Loading
, since dispatch depends on static types.
...edc/src/main/java/org/eclipse/tractusx/sde/edc/entities/request/asset/AssetEntryRequest.java Outdated

@JsonProperty("@id")
private String id;
private HashMap<String, String> properties;
private HashMap<String, Object> properties;

Check notice

Code scanning / CodeQL

Exposing internal representation Note

getProperties exposes the internal representation stored in field properties. The value may be modified
after this call to getProperties
Loading
.
getProperties exposes the internal representation stored in field properties. The value may be modified
after this call to getProperties
Loading
.
getProperties exposes the internal representation stored in field properties. The value may be modified
after this call to getProperties
Loading
.
sachinargade123
sachinargade123 approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@sachinargade123 sachinargade123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChetanT-System
Copy link
Contributor Author

@almadigabor Please review and merge the PR.

adityagajbhiye9
adityagajbhiye9 approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@adityagajbhiye9 adityagajbhiye9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@almadigabor almadigabor merged commit 69f7639 into eclipse-tractusx:main Apr 9, 2024
6 checks passed
@almadigabor almadigabor deleted the CX_PI12_S5_03 branch April 9, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityagajbhiye9 adityagajbhiye9 adityagajbhiye9 approved these changes

@sachinargade123 sachinargade123 sachinargade123 approved these changes

@almadigabor almadigabor almadigabor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChetanT-System @almadigabor @sachinargade123 @adityagajbhiye9