Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: TRG 5.11 Chart upgrading test #94

Merged
merged 3 commits into from
Nov 23, 2023
Merged

fix: TRG 5.11 Chart upgrading test #94

merged 3 commits into from
Nov 23, 2023

Conversation

adkumar1
Copy link
Contributor

@adkumar1 adkumar1 mentioned this pull request Nov 23, 2023
Closed
@adkumar1
Copy link
Contributor Author

@adityagajbhiye Please review

adityagajbhiye9
adityagajbhiye9 approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@adityagajbhiye9 adityagajbhiye9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@MehranRoshandel
Copy link

@SebastianBezold, can you please help us to merge this PR by today?

SebastianBezold
SebastianBezold approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@SebastianBezold SebastianBezold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SebastianBezold SebastianBezold merged commit 11013eb into eclipse-tractusx:main Nov 23, 2023
2 checks passed
@SebastianBezold SebastianBezold deleted the lint-fix branch November 23, 2023 12:25
@SebastianBezold
Copy link
Contributor

Had to re-open the issue. See my comment here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityagajbhiye9 adityagajbhiye9 adityagajbhiye9 approved these changes

@SebastianBezold SebastianBezold SebastianBezold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TRG 5.11 Chart upgrading test is not actually upgrading
4 participants
@adkumar1 @MehranRoshandel @SebastianBezold @adityagajbhiye9