This repository has been archived by the owner on Mar 12, 2024. It is now read-only.
remove unused components, fix bug #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove not required folders, fix OpenApi
carslen
approved these changes
Feb 14, 2023
There was a problem hiding this comment.
LGTM
Two recommendations for future pull requests:
- seperate changes in workflows, Helm Charts and changes in the code itself and handle them in different pull requests
- I know you're doing a review in the fork. Consider to do the review here in the Upstream. Even if you are not a committer yet, you can do the review here in the upstream repo and even approve :) See also our guide lines for Code Reviews, which were presented by @AngelikaWittek in recent system team office hour.
This has some advantages:
- You or anyone else who is doing the review/approval collects contributions which counts to getting a Eclipse Committer
- You can approve the programatic stuff and we need only to check for OSS/Leagal/Helm/workflow stuff
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @carslen, could you please check and merge this PR? It has been reviewed in this PR.
It includes:
Thanks