Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix helm user and group #60

Merged
merged 2 commits into from
Aug 23, 2023
Merged

fix: fix helm user and group #60

merged 2 commits into from
Aug 23, 2023

Conversation

pmoscode
Copy link
Contributor

@pmoscode pmoscode commented Aug 23, 2023

Description

The "runAsUser" and "runAsGroup" parameter was changed mistakenly for the securityContext.
This should match the userid and group from the Dockerfile.

Also updated the Readme and the unittest.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@pmoscode
Copy link
Contributor Author

@mknoopvw @borisrizov-zf @DominikPinsel
Please review.

Copy link
Contributor

@mknoopvw mknoopvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as it re-establishes conventions, e.g. the ID > 10000 rule.

Copy link
Contributor

@SebastianBezold SebastianBezold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SebastianBezold SebastianBezold merged commit c4dffac into eclipse-tractusx:develop Aug 23, 2023
@pmoscode pmoscode deleted the fix/helm-user-group branch August 25, 2023 07:34
RoKrish14 referenced this pull request in RoKrish14/managed-identity-wallet Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants