feat(helm): allow networkPolicy to template values #248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the networkPolicy was introduced in #246 it works as expected.
But for our usecase we need to restrict the networkPolicy to the installed namespace.
This is possible if the namespace will be selected with a matching label.
Therefore the use of the variable
.Releases.Namespace
is a common approach.With the current implementation templating of the values are not allowed.
This change will allow to template the values files (with a bitnami-common helpers).
Example
Without this PR the matchLabels would not be templated and still result in:
kubernetes.io/metadata.name: "{{ .Release.Namespace }}"
With these changes the result would be e.g.:
kubernetes.io/metadata.name: "default"
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:
Marco Lecheler [email protected] Mercedes-Benz Tech Innovation GmbH (ProviderInformation)