Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature : TX 2412 upgrade (TX EDC 0.8.0 release) #261

Merged

Conversation

drcgjung
Copy link
Contributor

WHAT

Adapts dependencies and base images to the TX EDC 0.8.0 release.

WHY

Provide the most possible compatibility of the agent planes.

FURTHER NOTES

Closes #35 # <-- insert Issue number if one exists

@drcgjung drcgjung added the enhancement New feature or request label Nov 22, 2024
@drcgjung
Copy link
Contributor Author

there is a "restricted" dependency
maven/mavencentral/org.flywaydb/flyway-database-postgresql/10.21.0, , restricted, clearlydefined
which comes through TX EDC ... an IP check should already been issued at eclipse, I would guess.

Copy link
Contributor

@almadigabor almadigabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor request.

DEPENDENCIES Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the DEPENDENCIES file before I merge the PR. There should be no restricted libraries once you run the dash tool.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are clear rules for commiters and there are the obvious exceptions

https://github.com/eclipse-tractusx/tractusx-edc/blob/25da0bc59107d8bc379d8162002698165ecefff9/DEPENDENCIES#L571

So If you could please open an IP check on that one line

maven/mavencentral/org.flywaydb/flyway-database-postgresql/10.21.0, , restricted, clearlydefined

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the process, might have been on a different branch when I ran the command. Now the IP ticket is created, let's wait for approval then the DEPENDENCIES file can be updated.

Output:

A review is required for maven/mavencentral/org.flywaydb/flyway-database-postgresql/10.21.0.
A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/17433 .

@almadigabor almadigabor merged commit da562d0 into eclipse-tractusx:main Dec 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Manually triggering the "Chart testing" workflow does skip the test
2 participants